Closed Bug 1258345 Opened 9 years ago Closed 9 years ago

Add apps/ to PRESERVE_DIRS in gonk-misc/Android.mk

Categories

(Firefox OS Graveyard :: GonkIntegration, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gerard-majax, Assigned: gerard-majax)

References

Details

Attachments

(1 file)

49 bytes, text/x-github-pull-request
gerard-majax
: review+
Details | Review
Gaia and gonk-misc have hardcoded paths to webapps/ (or apps/ for kanikani branch). I suggest we change this to GAIA_WEBAPPS_PATH to make it easier
In fact I guess it is a bad idea ...
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
We need it at least for user/userdebug images, because gonk-misc/Android.mk defines a list of directories to preserve and hardcodes webapps there.
Hacking it on gaia/ is mostly a waste of time because we cannot reliably make use of GAIA_PATH
Summary: Gaia webapps installation directory should be configurable → Add apps/ to PRESERVE_DIRS in gonk-misc/Android.mk
Attached file PR
Attachment #8732900 - Flags: review+
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
Tested extensively locally, rebuilt dozen of times with kanikani and master branch successfully.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: