1254367 - Remove old microformats parser now that we have the new microformats2 parser

Status: RESOLVED FIXED

(Toolkit Graveyard :: Microformats, defect)

Description

[Tantek Çelik]

Per commentary in https://bugzilla.mozilla.org/show_bug.cgi?id=1037483

Comment 1

[Florian Bender]

Is this still a thing after Bug 909633?

Comment 2

[Mike Kaply [:mkaply]]

Yes. This is about completely removing the old Microformats code and switching to microformats-shiv

Comment 3

[Mike Kaply [:mkaply]]

Attachment: Remove old microformats code and tests

This removes the code and tests.

The only add-on that uses it is huffduffer. I have an email in to Jeremy Keith.

I couldn't find any explicit change that was causing tests to be run.

Comment 4

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8770283 [details] [diff] [review]
Remove  old microformats code and tests

LGTM

Comment 5

[Mike Kaply [:mkaply]]

Attachment: Bug 1254367 - Remove old microformats parser (replaced with microformat-shiv).

Review commit: https://reviewboard.mozilla.org/r/65264/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/65264/

Comment 6

[Mike Kaply [:mkaply]]

Shane:

I moved this to mozreview (I'm going to autoland/autotry) plus I decided to make you the reviewer :).

If you don't mind just r= again in MozReview. Tx.

Comment 7

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8772462 [details]
Bug 1254367 - Remove old microformats parser (replaced with microformat-shiv).

https://reviewboard.mozilla.org/r/65264/#review62290

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/76631f34f9bc
Remove old microformats parser (replaced with microformat-shiv). r=mixedpuppy

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/76631f34f9bc

Comment 10

[Tantek Çelik]

(In reply to Mike Kaply [:mkaply] from comment #3)
> Created attachment 8770283 [details] [diff] [review]
> Remove  old microformats code and tests
> 
> This removes the code and tests.

Thanks for pushing this through Mike.

> The only add-on that uses it is huffduffer. I have an email in to Jeremy
> Keith.

Did you hear back from Jeremy Keith? 
Was/is he able to update huffduffer to use our microformat-shiv interface instead?

Comment 11

[Tantek Çelik]

Comment on attachment 8770283 [details] [diff] [review]
Remove  old microformats code and tests

Review of attachment 8770283 [details] [diff] [review]:
-----------------------------------------------------------------

r+ if we get an email reply from Jeremy Keith confirming he's able to update huffduffer to use microformats-shiv.

Comment 12

[Mike Kaply [:mkaply]]

Jeremy did say he was updating huffduffer.

This won't hit until Firefox 50, so he has some time to do that.