Closed Bug 1254367 Opened 4 years ago Closed 3 years ago

Remove old microformats parser now that we have the new microformats2 parser

Categories

(Toolkit Graveyard :: Microformats, defect)

defect
Not set

Tracking

(firefox50 fixed)

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: tantek, Assigned: mkaply)

References

Details

Attachments

(2 files)

Depends on: 1237480
Is this still a thing after Bug 909633?
Yes. This is about completely removing the old Microformats code and switching to microformats-shiv
This removes the code and tests.

The only add-on that uses it is huffduffer. I have an email in to Jeremy Keith.

I couldn't find any explicit change that was causing tests to be run.
Attachment #8770283 - Flags: review?(tantek)
Attachment #8770283 - Flags: feedback?(mixedpuppy)
Comment on attachment 8770283 [details] [diff] [review]
Remove  old microformats code and tests

LGTM
Attachment #8770283 - Flags: feedback?(mixedpuppy) → feedback+
Shane:

I moved this to mozreview (I'm going to autoland/autotry) plus I decided to make you the reviewer :).

If you don't mind just r= again in MozReview. Tx.
Comment on attachment 8772462 [details]
Bug 1254367 - Remove old microformats parser (replaced with microformat-shiv).

https://reviewboard.mozilla.org/r/65264/#review62290
Attachment #8772462 - Flags: review?(mixedpuppy) → review+
Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/76631f34f9bc
Remove old microformats parser (replaced with microformat-shiv). r=mixedpuppy
https://hg.mozilla.org/mozilla-central/rev/76631f34f9bc
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
(In reply to Mike Kaply [:mkaply] from comment #3)
> Created attachment 8770283 [details] [diff] [review]
> Remove  old microformats code and tests
> 
> This removes the code and tests.

Thanks for pushing this through Mike.

> The only add-on that uses it is huffduffer. I have an email in to Jeremy
> Keith.

Did you hear back from Jeremy Keith? 
Was/is he able to update huffduffer to use our microformat-shiv interface instead?
Comment on attachment 8770283 [details] [diff] [review]
Remove  old microformats code and tests

Review of attachment 8770283 [details] [diff] [review]:
-----------------------------------------------------------------

r+ if we get an email reply from Jeremy Keith confirming he's able to update huffduffer to use microformats-shiv.
Attachment #8770283 - Flags: review?(tantek) → review+
Jeremy did say he was updating huffduffer.

This won't hit until Firefox 50, so he has some time to do that.
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.