If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Take ownership of error reporting on the AutoEntryScript in nsXPCWrappedJSClass::CallMethod

RESOLVED FIXED in Firefox 48

Status

()

Core
XPConnect
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

(Blocks: 1 bug)

Trunk
mozilla48
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(1 attachment)

Still trying to get this green on try, because of silliness like bug 1253891 and bug 1254230 and the like.  But figure I should at least get the patch saved somewhere other than my hard drive.
Created attachment 8727702 [details] [diff] [review]
Take ownership of error reporting on the AutoEntryScript in nsXPCWrappedJSClass::CallMethod

Please pay attention to the second of the two behavior changes listed.  It's actually causing some issues in terms of orange on try, so maybe we _don't_ want it... hard to say.
Attachment #8727702 - Flags: review?(bobbyholley)
Comment on attachment 8727702 [details] [diff] [review]
Take ownership of error reporting on the AutoEntryScript in nsXPCWrappedJSClass::CallMethod

Review of attachment 8727702 [details] [diff] [review]:
-----------------------------------------------------------------

This looks great. I'm fine with the corner-case behavior change if it makes things simpler.

::: browser/components/preferences/in-content/advanced.js
@@ +358,5 @@
>        onNetworkCacheDiskConsumption: function(consumption) {
>          var size = DownloadUtils.convertByteUnits(consumption);
>          // The XBL binding for the string bundle may have been destroyed if
>          // the page was closed before this callback was executed.
> +        Math.sin();

I don't think you want the changes in this file, here or below.
Attachment #8727702 - Flags: review?(bobbyholley) → review+

Comment 3

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/f31818f56cd2

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f31818f56cd2
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox48: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.