1254393 - Take ownership of error reporting on the AutoEntryScript in nsXPCWrappedJSClass::CallMethod

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Still trying to get this green on try, because of silliness like bug 1253891 and bug 1254230 and the like.  But figure I should at least get the patch saved somewhere other than my hard drive.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Take ownership of error reporting on the AutoEntryScript in nsXPCWrappedJSClass::CallMethod

Please pay attention to the second of the two behavior changes listed.  It's actually causing some issues in terms of orange on try, so maybe we _don't_ want it... hard to say.

Comment 2

[Bobby Holley (:bholley)]

Comment on attachment 8727702 [details] [diff] [review]
Take ownership of error reporting on the AutoEntryScript in nsXPCWrappedJSClass::CallMethod

Review of attachment 8727702 [details] [diff] [review]:
-----------------------------------------------------------------

This looks great. I'm fine with the corner-case behavior change if it makes things simpler.

::: browser/components/preferences/in-content/advanced.js
@@ +358,5 @@
>        onNetworkCacheDiskConsumption: function(consumption) {
>          var size = DownloadUtils.convertByteUnits(consumption);
>          // The XBL binding for the string bundle may have been destroyed if
>          // the page was closed before this callback was executed.
> +        Math.sin();

I don't think you want the changes in this file, here or below.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f31818f56cd2

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f31818f56cd2