Closed Bug 1254596 Opened 4 years ago Closed 4 years ago
Reply with selection doesn't work any more
I've just switched from TB 46 (was Earlybird) to TB 47 (now Earlybird). When I select a text in an e-mail and press reply, the whole e-mail is quoted in the reply and not just the selected text. I wonder when/how that broke. Also not working on latest trunk TB 48.
This won't be so easy to find. The last good version was Daily of 2016-01-30. Builds were busted until 2016-02-04 due to the DOM windows stuff (bug 1243760). Immediately when that landed and we could build again, composition was busted due to bug 1245681. Aleth manually cancelled Dailies on the 4th and 5th. One Daily slipped through was built on 6th with busted composition. The daily that was built on the 2016-02-07 after bug 1245681 landed on M-C already has working composition, but the reply with selection doesn't work. So the problem occurred anywhere between the 2016-01-30 and the 2016-02-07. Bisecting won't help.
Sigh, no one really understood whether it needed to be outer or inner window. Ratty chose to the best of his abilities in bug 1243760 and I checked them all. Well, we got at least one wrong, this one.
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
Attachment #8728001 - Flags: review?(mkmelin+mozilla)
Comment on attachment 8728001 [details] [diff] [review] Revert bad choice made in bug 1243760 rs+ = me.
Attachment #8728001 - Flags: review?(mkmelin+mozilla) → review+
Comment on attachment 8728001 [details] [diff] [review] Revert bad choice made in bug 1243760 [Approval Request Comment] Regression caused by (bug #): bug 1243760 User impact if declined: Reply doesn't work, not so nice for an e-mail program. Testing completed (on c-c, etc.): Manual. Risk to taking this patch (and alternatives if risky): Not taking it is no option.
Attachment #8728001 - Flags: approval-comm-aurora+
Landed on Aurora (TB 47): https://hg.mozilla.org/releases/comm-aurora/rev/bf9217456d7b
You need to log in before you can comment on or make changes to this bug.