1254669 - Tab progress listener doesn't know that browser starts at blank after remoteness flip

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

We have these mTabProgressListener's attached to each tab that gets created. There's an mBlank property in each listener that causes the listener to ignore and not dispatch nsIWebProgressListener events until _after_ the initial about:blank of a browser has finished being browsed away from.

Anytime we flip remoteness, we re-use the same listener, and we don't restore the mBlank property to its initial state. That means after the remoteness flip, we pass progress events through from the about:blank load.

This causes us, among other things, to update the tab title and spinner state uselessly, which results in us painting, which causes the parent to be busy when it probably shouldn't be. This is, I believe, hurting us on our tpaint scores.

This is a relatively easy fix. I'll see if I can get a sense of how much of a tpaint win (if any) we can expect here. (It might only bear fruit with other work, like combining sync messages in the child).

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: MozReview Request: Bug 1254669 - Create a new mTabProgressListener for a browser when flipping remoteness. r?felipe

Review commit: https://reviewboard.mozilla.org/r/38773/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/38773/

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8728069 [details]
MozReview Request: Bug 1254669 - Create a new mTabProgressListener for a browser when flipping remoteness. r?felipe

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/38773/diff/1-2/

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8728069 [details]
MozReview Request: Bug 1254669 - Create a new mTabProgressListener for a browser when flipping remoteness. r?felipe

https://reviewboard.mozilla.org/r/38773/#review35543

Comment 4

[GitHub Autolander Bot]

Attachment: [loop] daveccrit:1254699-npsSurvey2 > mozilla:master

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b62e261d5ff8

Comment 6

[Mike Conley (:mconley) (:⚙️)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a781444b0495

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b62e261d5ff8