1254774 - error: member access into incomplete type 'nsIUUIDGenerator' after bug 1237847

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect)

Description

[Patrick Cloke [:clokep]]

Attachment: Build log

I'm getting build errors in toolkit/xre/nsAppRunner.cpp after bug 1237847 landed. (I verified by backing out 5b20181a5b50 and my build completed).

The error is:

Unified_cpp_toolkit_xre0.o
/Users/pcloke/mozilla/comm-central/mozilla/toolkit/xre/nsAppRunner.cpp:689:17: error: member access into incomplete type 'nsIUUIDGenerator'
    rv = uuidgen->GenerateUUIDInPlace(&uuid);
                ^

I've attached a partial build log.

I suspect this is because I have --disable-accessibility. (https://hg.mozilla.org/mozilla-central/annotate/05c087337043dd8e71cc27bdb5b9d55fd00aaa26/toolkit/xre/nsAppRunner.cpp#l117 maybe similar to bug 990793?)

Comment 1

[Patrick Cloke [:clokep]]

Attachment: Patch v1

I'm not really sure who the right reviewer for this code is, so I chose the same reviewer as bug 1237847, please let me know if this is incorrect.

(I suspect I also filed this bug in the wrong component, but again...I matched the bug that caused the regression.)

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8728166 [details] [diff] [review]
Patch v1

Review of attachment 8728166 [details] [diff] [review]:
-----------------------------------------------------------------

I can take this. r=me.

Comment 3

[Patrick Cloke [:clokep]]

Thanks!

https://hg.mozilla.org/integration/mozilla-inbound/rev/ba36ba7f03c8

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ba36ba7f03c8