58 bytes, text/x-review-board-request
Adding, for instance set_define('SPIDERMONKEY_PROMISE', True) fails with: 0:06.06 js/src> File "./config.status", line 433, in <module> 0:06.06 js/src> "SPIDERMONKEY_PROMISE": true, 0:06.06 js/src> NameError: name 'true' is not defined
The way we're writing config.status means everything we put in the config needs to JSON serialize to valid Python. We could add a special case convert True to '1', or just have set_config or set_define with one argument mean the corresponding value ends up in the config as '1' to make this more convenient to write.
I was thinking adding something like: true, false, null = True, False, None
Review commit: https://reviewboard.mozilla.org/r/40257/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/40257/
Attachment #8730943 - Flags: review?(cmanchester)
Comment on attachment 8730943 [details] MozReview Request: Bug 1254884 - Make JSON serialization to config.status more readable as python https://reviewboard.mozilla.org/r/40257/#review36791 Sure.
Attachment #8730943 - Flags: review?(cmanchester) → review+
You need to log in before you can comment on or make changes to this bug.