1254884 - Can't use booleans in set_config() or set_define()

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

Adding, for instance set_define('SPIDERMONKEY_PROMISE', True) fails with:

 0:06.06 js/src>   File "./config.status", line 433, in <module>
 0:06.06 js/src>     "SPIDERMONKEY_PROMISE": true,
 0:06.06 js/src> NameError: name 'true' is not defined

Comment 1

[Chris Manchester (limited bugmail, email directly)]

The way we're writing config.status means everything we put in the config needs to JSON serialize to valid Python.

We could add a special case convert True to '1', or just have set_config or set_define with one argument mean the corresponding value ends up in the config as '1' to make this more convenient to write.

Comment 2

[Mike Hommey [:glandium]]

I was thinking adding something like: true, false, null = True, False, None

Comment 3

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1254884 - Make JSON serialization to config.status more readable as python

Review commit: https://reviewboard.mozilla.org/r/40257/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40257/

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8730943 [details]
MozReview Request: Bug 1254884 - Make JSON serialization to config.status more readable as python

https://reviewboard.mozilla.org/r/40257/#review36791

Sure.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c916fde5ebb3

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c916fde5ebb3