Closed Bug 1254923 Opened 4 years ago Closed 4 years ago

Remove RemoveAllPages API

Categories

(Toolkit :: Places, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: mak, Assigned: tvaleev, Mentored)

References

Details

(Whiteboard: [good first bug][lang=cpp])

Attachments

(1 file)

RemoveAllPages was deprecated in Firefox 45, we should remove it from Firefox 48 on

http://mxr.mozilla.org/mozilla-central/search?string=removeallpages
(ignoring the puppeteer piece that will be fixed in bug 1249259
Hi! Please review.
Attachment #8728471 - Flags: review?(mak77)
Assignee: nobody → tvaleev
Status: NEW → ASSIGNED
Comment on attachment 8728471 [details] [diff] [review]
bug-1254923-fix.patch

Review of attachment 8728471 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you it looks good.

We just have to wait for the dependency bug to land first, then we can land this.
Attachment #8728471 - Flags: review?(mak77) → review+
Flags: needinfo?(mak77)
this is a plain removal of a not used API, so I'm not triggering a try run for it, since it would be a waste of resources.
Keywords: checkin-needed
Flags: needinfo?(mak77)
https://hg.mozilla.org/mozilla-central/rev/3eb3406f08b5
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.