1254928 - Remove or pref off non-standard IDB extensions

Status: NEW

(Core :: Storage: IndexedDB, task, P3)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

I found:

* createMutableFile
* mozCreateFileHandle
* IDBFileRequest
* IDBFileHandle

and there's probably a bunch more I didn't find. Nobody else seems interested in supporting them, so we should not ship them in release.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

* IDBMutableFile

Comment 2

[Jan Varga [:janv]]

I know at least one site that uses this stuff, www.peer5.com
Guy Paskar should know more.

The plan is to extend current MutableFile implementation to support the new FileSystem API and once that ships and sites adjust to it, we'll remove createMutableFile, etc. from IndexedDB.

Comment 3

[Andrew Overholt [:overholt]]

(In reply to Jan Varga [:janv] from comment #2)
> I know at least one site that uses this stuff, www.peer5.com
> Guy Paskar should know more.

Does peer5.com do something different for other browsers?
 
> The plan is to extend current MutableFile implementation to support the new
> FileSystem API and once that ships and sites adjust to it, we'll remove
> createMutableFile, etc. from IndexedDB.

It's not clear we're going to implement the FileSystem API in the short term.

Comment 4

[Jan Varga [:janv]]

(In reply to Andrew Overholt [:overholt] from comment #3)
> (In reply to Jan Varga [:janv] from comment #2)
> > I know at least one site that uses this stuff, www.peer5.com
> > Guy Paskar should know more.
> 
> Does peer5.com do something different for other browsers?

Yes, I think they use google's filesystem api.

>  
> > The plan is to extend current MutableFile implementation to support the new
> > FileSystem API and once that ships and sites adjust to it, we'll remove
> > createMutableFile, etc. from IndexedDB.
> 
> It's not clear we're going to implement the FileSystem API in the short term.

Yeah and the current FileHandle in IndexedDB doesn't do any big harm, so I think we should just keep it for now.

Comment 5

[Mike Taylor [:miketaylr]]

I think we should add use counter telemetry to measure how much these are used in the wild. Will file a bug.

Comment 6

[Denis Lisov]

Is the IDB MutableFile support going to be available to WebExtensions? Migrating an addon to a WebExtension, shall I consider these interfaces to be stable and available or deprecated?

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

The features in this bug are not in any web standard and are not implemented in any other browser. I would generally assume that such features will be removed eventually.

Comment 8

[Henri Sivonen (:hsivonen)]

I'd like us to remove https://developer.mozilla.org/en-US/docs/Web/API/IndexedDB_API/Using_IndexedDB#locale-aware_sorting , which according to MDN is behind a flag anyway. Reason: Removing the dependency on collation key objects so that ICU4X collator MVP doesn't need to support collation key objects.