Closed Bug 1271457 Opened 4 years ago Closed 3 years ago

Add use counter telemetry for non-standard IDB extensions

Categories

(Core :: Storage: IndexedDB, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: miketaylr, Assigned: overholt)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch bug1271457.patch (obsolete) — Splinter Review
Jan, is annotating createMutableFile and mozCreateFileHandle like this enough to catch usage of MutableFile and FileHandle?
Flags: needinfo?(jvarga)
Assignee: nobody → overholt
(In reply to Andrew Overholt [:overholt] from comment #1)
> Created attachment 8833298 [details] [diff] [review]
> bug1271457.patch
> 
> Jan, is annotating createMutableFile and mozCreateFileHandle like this
> enough to catch usage of MutableFile and FileHandle?

I would also add IDBMutableFile.open and IDBMutableFile.getFile
Flags: needinfo?(jvarga)
Attached patch bug1271457.patchSplinter Review
Benjamin, do I need a data steward review here? The thread from August 2015 seemed inconclusive.
Attachment #8833298 - Attachment is obsolete: true
Flags: needinfo?(benjamin)
Attachment #8834736 - Flags: review?(jvarga)
Comment on attachment 8834736 [details] [diff] [review]
bug1271457.patch

Review of attachment 8834736 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Attachment #8834736 - Flags: review?(jvarga) → review+
Yes, you do.
Flags: needinfo?(benjamin)
Comment on attachment 8834736 [details] [diff] [review]
bug1271457.patch

It's really unfortunate that use counters don't support any of the normal expiration mechanisms of other telemetry probes. This is an obvious candidate for data collection that expires automatically.

Since we technically don't have that, I'm going to mark data-r+ here, but please file a followup bug to remove this after you no longer need it, and maybe make sure there's a bug filed so that use counters *can* expire and choose opt-in/opt-out like all other telemetry?
Attachment #8834736 - Flags: feedback+
Component: Telemetry → DOM: IndexedDB
Product: Toolkit → Core
Blocks: 1338603
(In reply to Benjamin Smedberg [:bsmedberg] from comment #6)
> It's really unfortunate that use counters don't support any of the normal
> expiration mechanisms of other telemetry probes. This is an obvious
> candidate for data collection that expires automatically.

I filed bug 1338603 for this.

> please file a followup bug to remove this after you no longer need it, and
> maybe make sure there's a bug filed so that use counters *can* expire and
> choose opt-in/opt-out like all other telemetry?

I filed bug 1338606 for this.
Try result looks good. Please land.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/52f57ab9685b
Add use counters for non-standard IDB extensions. r=janv, r=qDot
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/52f57ab9685b
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.