1271457 - Add use counter telemetry for non-standard IDB extensions

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Mike Taylor [:miketaylr]]

See https://dxr.mozilla.org/mozilla-central/source/dom/base/UseCounters.conf for docs on how to do this.

Comment 1

[Andrew Overholt [:overholt]]

Attachment: bug1271457.patch

Jan, is annotating createMutableFile and mozCreateFileHandle like this enough to catch usage of MutableFile and FileHandle?

Comment 2

[Jan Varga [:janv]]

(In reply to Andrew Overholt [:overholt] from comment #1)
> Created attachment 8833298 [details] [diff] [review]
> bug1271457.patch
> 
> Jan, is annotating createMutableFile and mozCreateFileHandle like this
> enough to catch usage of MutableFile and FileHandle?

I would also add IDBMutableFile.open and IDBMutableFile.getFile

Comment 3

[Andrew Overholt [:overholt]]

Attachment: bug1271457.patch

Benjamin, do I need a data steward review here? The thread from August 2015 seemed inconclusive.

Comment 4

[Jan Varga [:janv]]

Comment on attachment 8834736 [details] [diff] [review]
bug1271457.patch

Review of attachment 8834736 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 5

[Benjamin Smedberg]

Yes, you do.

Comment 6

[Benjamin Smedberg]

Comment on attachment 8834736 [details] [diff] [review]
bug1271457.patch

It's really unfortunate that use counters don't support any of the normal expiration mechanisms of other telemetry probes. This is an obvious candidate for data collection that expires automatically.

Since we technically don't have that, I'm going to mark data-r+ here, but please file a followup bug to remove this after you no longer need it, and maybe make sure there's a bug filed so that use counters *can* expire and choose opt-in/opt-out like all other telemetry?

Comment 7

[Andrew Overholt [:overholt]]

(In reply to Benjamin Smedberg [:bsmedberg] from comment #6)
> It's really unfortunate that use counters don't support any of the normal
> expiration mechanisms of other telemetry probes. This is an obvious
> candidate for data collection that expires automatically.

I filed bug 1338603 for this.

> please file a followup bug to remove this after you no longer need it, and
> maybe make sure there's a bug filed so that use counters *can* expire and
> choose opt-in/opt-out like all other telemetry?

I filed bug 1338606 for this.

Comment 8

[Andrew Overholt [:overholt]]

Try build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=697d9ec1e397fb0b7955f8ad3f8339f28ec6341e

Comment 9

[Andrew Overholt [:overholt]]

Try result looks good. Please land.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/52f57ab9685b
Add use counters for non-standard IDB extensions. r=janv, r=qDot

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/52f57ab9685b