1254956 - Implement Node.rootNode

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

This is a recent addition to the DOM spec. Webkit and Blink are implementing it.
Internally we have nsINode::SubtreeRoot() which, if I recall correctly, should map exactly to Node.rootNode

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

FYI, there are some web-platform-tests coming from Apple.
Trying to find a link to those

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

https://github.com/w3c/web-platform-tests/pull/2665

Comment 3

[Jocelyn Liu [:jocelyn] [:joliu]]

(In reply to Olli Pettay [:smaug] from comment #2)
> https://github.com/w3c/web-platform-tests/pull/2665

I added |RootNode()| method which basically just call |SubtreeRoot()|.
And applied this patch under testing/web-platform/tests, no new fail cases when I ran ./mach web-platform-tests testing/web-platform/tests/dom/interfaces.html.

But when I ran ./mach web-platform-tests testing/web-platform/tests/dom/nodes/rootNode.html, it said "No testharness tests to run" and 0 tests were ran.
Not sure what I'm missing here...

Comment 4

[Jocelyn Liu [:jocelyn] [:joliu]]

(In reply to Jocelyn Liu [:jocelyn] [:joliu] from comment #3)
> (In reply to Olli Pettay [:smaug] from comment #2)
> > https://github.com/w3c/web-platform-tests/pull/2665
> 
> I added |RootNode()| method which basically just call |SubtreeRoot()|.
> And applied this patch under testing/web-platform/tests, no new fail cases
> when I ran ./mach web-platform-tests
> testing/web-platform/tests/dom/interfaces.html.
> 
> But when I ran ./mach web-platform-tests
> testing/web-platform/tests/dom/nodes/rootNode.html, it said "No testharness
> tests to run" and 0 tests were ran.
> Not sure what I'm missing here...

OK, it turns out to be a silly one, I forgot to update the manifest.
Now all tests are passed.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

I think we could then land the patch (after a review) and just wait a tiny bit to get those automated tests for free.
wpt->mozilla-central merge should happen quite often.

Comment 6

[Jocelyn Liu [:jocelyn] [:joliu]]

Attachment: MozReview Request: Bug 1254956 - Implement Node.rootNode. r?smaug, r=Ms2ger

Review commit: https://reviewboard.mozilla.org/r/40771/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40771/

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8731677 [details]
MozReview Request: Bug 1254956 - Implement Node.rootNode. r?smaug, r=Ms2ger

https://reviewboard.mozilla.org/r/40771/#review37277

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5eb1f8858a31

Comment 9

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c4891e18a54f

Comment 10

[Carsten Book [:Tomcat]]

backed out for problems like https://treeherder.mozilla.org/logviewer.html#?job_id=24216639&repo=mozilla-inbound

Comment 11

[Jocelyn Liu [:jocelyn] [:joliu]]

Sorry for the inconvenience, I didn't notice that web-platform test is already synced to our repo and marked as expected FAIL, will fix that and re-land my patch.

Comment 12

[Jocelyn Liu [:jocelyn] [:joliu]]

Comment on attachment 8731677 [details]
MozReview Request: Bug 1254956 - Implement Node.rootNode. r?smaug, r=Ms2ger

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40771/diff/1-2/

Comment 13

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 8731677 [details]
MozReview Request: Bug 1254956 - Implement Node.rootNode. r?smaug, r=Ms2ger

https://reviewboard.mozilla.org/r/40771/#review37849

Stealing... r=smaug on the code changes, r=me on the test expectation updates.

Comment 14

[Jocelyn Liu [:jocelyn] [:joliu]]

Comment on attachment 8731677 [details]
MozReview Request: Bug 1254956 - Implement Node.rootNode. r?smaug, r=Ms2ger

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40771/diff/2-3/

Comment 15

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3bc53f14f51e

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3bc53f14f51e

Comment 17

[Eric Shepherd [:sheppy]]

Doc updates underway. Will finish this evening.

Comment 18

[Eric Shepherd [:sheppy]]

Updated:

https://developer.mozilla.org/en-US/docs/Web/API/Node/rootNode
https://developer.mozilla.org/en-US/docs/Web/API/Node#Properties

Updated Firefox 48 for developers.