Remove unused nsICookiePromptService

RESOLVED FIXED in Firefox 53

Status

()

defect
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: Margaret, Assigned: standard8)

Tracking

(Blocks 1 bug)

Trunk
mozilla53
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 affected, firefox53 fixed)

Details

(Whiteboard: [necko-backlog])

Attachments

(1 attachment)

Looking through the tree, I don't actually see any consumers of nsICookiePromptService. I think the last consumer might have been remove in bug 606655.

This is of interest to me because we want to remove the XUL UI dependency from Fennec, but the only way to do that is to implement our own native UI, and I don't want to spend time doing that (bug 1236407).
FYI, https://mxr.mozilla.org/addons/search?string=nsicookiepromptservice shows it being used by r2d2b2g, as well as two other addons.
One is Pubget, the other is explicitly Cookie Prompter Add-on which is for FF Android.
I don't think we should support an old unused API in our products only for add-ons, especially one that was not explicitly intended for add-ons.

(In reply to Josh Matthews [:jdm] from comment #1)
> FYI, https://mxr.mozilla.org/addons/search?string=nsicookiepromptservice
> shows it being used by r2d2b2g, as well as two other addons.

Is r2d2b2g even still supported? Even if it is, I don't think it should block our Firefox product decisions.

(In reply to Josh Matthews [:jdm] from comment #2)
> One is Pubget, the other is explicitly Cookie Prompter Add-on which is for
> FF Android.

I don't see Pubget on AMO, but cookie prompter has only 63 users:
https://addons.mozilla.org/en-US/android/addon/cookieprompter/
Whiteboard: [necko-backlog]
In doing work for bug 1311312, I've determined that doSetOKCancel was removed by bug 1312143 in Firefox 52 (now on Aurora), which completely breaks the prompt.

https://dxr.mozilla.org/mozilla-central/rev/c91249f41e3766274131a84f9157a4d9d9949520/toolkit/components/cookie/content/cookieAcceptDialog.js#23

Since we have no uses, I've also looked at the add-on sources in dxr, and as far as I can tell, no-one uses the prompt service now.

Hence, I think we can just remove this now.
Assignee: nobody → standard8
Blocks: 1311312, 1312143
I just looked at the addons DXR as well, and the situation appears unchanged from comment 2. That being said, I agree with comment 3 (and I can't find any link to the pubget extension from the pubget website, either, though links on blog posts still work).
Comment on attachment 8823236 [details]
Bug 1255149 - Remove unused nsICookiePromptService.

https://reviewboard.mozilla.org/r/101806/#review102334
Attachment #8823236 - Flags: review?(josh) → review+
The remaining add-on uses don't matter. The references in r2d2 (which isn't supported anyway) are part of b2g, not the add-on, and the other uses were broken when we stopped supporting cookie prompts.
The updated patch is to fix bitrot due to a eslint bug landing, and to also remove "cookies.xpt" from all the package-manifest.in files.
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/82b9d18725b9
Remove unused nsICookiePromptService. r=jdm
https://hg.mozilla.org/mozilla-central/rev/82b9d18725b9
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.