Closed Bug 1311312 Opened 9 years ago Closed 8 years ago

[meta] Enable eslint rule no-undef in toolkit/.eslintrc.js (and everywhere that covers)

Categories

(Firefox :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: standard8, Assigned: standard8)

References

Details

no-undef is very useful for picking up mistakes and referencing of unknown variables. We should enable it on browser/ This work is likely to cross several bugs, so this is the tracker for it.
:standard8, is this bug ready to resolve? if not, lets put some bugs or next steps in here so we can see what remains.
Flags: needinfo?(standard8)
(In reply to Joel Maher ( :jmaher) from comment #1) > :standard8, is this bug ready to resolve? if not, lets put some bugs or > next steps in here so we can see what remains. I just filed Bug 1323167 as the next big one - we need to sort out how we're dealing with the content code. I think this will fix the majority of the ~5000 errors that we have remaining when we enable no-undef. I don't think its worth filing others until we get that one resolved.
Flags: needinfo?(standard8)
Summary: [meta] Enable eslint rule no-undef on browser/* → [meta] Enable eslint rule no-undef in toolkit/.eslintrc.js (and everywhere that covers)
We're now down to about 3500 errors in my local tree, and I'm mainly driving the patches through for these, so I'll take the meta bug for now.
Assignee: nobody → standard8
I'm declaring this done. We've got it enabled pretty much everywhere that toolkit used to cover (now a recommended config). There's some tidy up to do, but I'll work on that in separate bugs.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.