[meta] Enable eslint rule no-undef in toolkit/.eslintrc.js (and everywhere that covers)

RESOLVED FIXED

Status

()

Firefox
General
RESOLVED FIXED
10 months ago
4 months ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

no-undef is very useful for picking up mistakes and referencing of unknown variables. We should enable it on browser/

This work is likely to cross several bugs, so this is the tracker for it.
Depends on: 1311315
Depends on: 1312355
Depends on: 1312716
Depends on: 1303525
Depends on: 1313626
Depends on: 1313634
:standard8, is this bug ready to resolve?  if not, lets put some bugs or next steps in here so we can see what remains.
Flags: needinfo?(standard8)
Depends on: 1323167
(In reply to Joel Maher ( :jmaher) from comment #1)
> :standard8, is this bug ready to resolve?  if not, lets put some bugs or
> next steps in here so we can see what remains.

I just filed Bug 1323167 as the next big one - we need to sort out how we're dealing with the content code. I think this will fix the majority of the ~5000 errors that we have remaining when we enable no-undef.

I don't think its worth filing others until we get that one resolved.
Flags: needinfo?(standard8)
Depends on: 1325374
Summary: [meta] Enable eslint rule no-undef on browser/* → [meta] Enable eslint rule no-undef in toolkit/.eslintrc.js (and everywhere that covers)
Depends on: 1325623
Depends on: 1255149
Depends on: 1328254
Depends on: 1328338
Depends on: 1328565
Depends on: 1328851
Depends on: 1329614
Depends on: 1330545
Depends on: 527444
Depends on: 1331006
Depends on: 503613
Depends on: 1333044
Depends on: 1335813
Depends on: 1336070
Blocks: 1229856
Depends on: 1337480
Depends on: 1338121
Depends on: 1338195
Depends on: 1338249
We're now down to about 3500 errors in my local tree, and I'm mainly driving the patches through for these, so I'll take the meta bug for now.
Assignee: nobody → standard8
Depends on: 1341019
Depends on: 1341029
Depends on: 1342427
Depends on: 1342459
Depends on: 1343519
I'm declaring this done. We've got it enabled pretty much everywhere that toolkit used to cover (now a recommended config). There's some tidy up to do, but I'll work on that in separate bugs.
Status: NEW → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.