1311312 - [meta] Enable eslint rule no-undef in toolkit/.eslintrc.js (and everywhere that covers)

Status: RESOLVED FIXED

Description

[Mark Banner (:standard8) (afk 11 - 20 Aug)]

no-undef is very useful for picking up mistakes and referencing of unknown variables. We should enable it on browser/

This work is likely to cross several bugs, so this is the tracker for it.

Comment 1

[Joel Maher ( :jmaher) (UTC-5)]

:standard8, is this bug ready to resolve?  if not, lets put some bugs or next steps in here so we can see what remains.

Comment 2

[Mark Banner (:standard8) (afk 11 - 20 Aug)]

(In reply to Joel Maher ( :jmaher) from comment #1)
> :standard8, is this bug ready to resolve?  if not, lets put some bugs or
> next steps in here so we can see what remains.

I just filed Bug 1323167 as the next big one - we need to sort out how we're dealing with the content code. I think this will fix the majority of the ~5000 errors that we have remaining when we enable no-undef.

I don't think its worth filing others until we get that one resolved.

Comment 3

[Mark Banner (:standard8) (afk 11 - 20 Aug)]

We're now down to about 3500 errors in my local tree, and I'm mainly driving the patches through for these, so I'll take the meta bug for now.

Comment 4

[Mark Banner (:standard8) (afk 11 - 20 Aug)]

I'm declaring this done. We've got it enabled pretty much everywhere that toolkit used to cover (now a recommended config). There's some tidy up to do, but I'll work on that in separate bugs.