Last Comment Bug 1311312 - [meta] Enable eslint rule no-undef in toolkit/.eslintrc.js (and everywhere that covers)
: [meta] Enable eslint rule no-undef in toolkit/.eslintrc.js (and everywhere th...
Status: NEW
:
Product: Firefox
Classification: Client Software
Component: General (show other bugs)
: unspecified
: Unspecified Unspecified
-- normal (vote)
: ---
Assigned To: Mark Banner (:standard8)
:
:
Mentors:
Depends on: 1342427 1342459 503613 527444 1255149 1303525 1311315 1312355 1312716 1313626 1313634 1323167 1325374 1325623 1328254 1328338 1328565 1328851 1329614 1330545 1331006 1333044 1335813 1336070 1337480 1338121 1338195 1338249 1341019 1341029
Blocks: eslint
  Show dependency treegraph
 
Reported: 2016-10-19 04:09 PDT by Mark Banner (:standard8)
Modified: 2017-02-24 08:45 PST (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments

Description User image Mark Banner (:standard8) 2016-10-19 04:09:29 PDT
no-undef is very useful for picking up mistakes and referencing of unknown variables. We should enable it on browser/

This work is likely to cross several bugs, so this is the tracker for it.
Comment 1 User image Joel Maher ( :jmaher) 2016-12-12 12:41:18 PST
:standard8, is this bug ready to resolve?  if not, lets put some bugs or next steps in here so we can see what remains.
Comment 2 User image Mark Banner (:standard8) 2016-12-13 02:59:28 PST
(In reply to Joel Maher ( :jmaher) from comment #1)
> :standard8, is this bug ready to resolve?  if not, lets put some bugs or
> next steps in here so we can see what remains.

I just filed Bug 1323167 as the next big one - we need to sort out how we're dealing with the content code. I think this will fix the majority of the ~5000 errors that we have remaining when we enable no-undef.

I don't think its worth filing others until we get that one resolved.
Comment 3 User image Mark Banner (:standard8) 2017-02-10 03:23:25 PST
We're now down to about 3500 errors in my local tree, and I'm mainly driving the patches through for these, so I'll take the meta bug for now.

Note You need to log in before you can comment on or make changes to this bug.