1255362 - Crash in mozilla::layers::ImageContainer::GetCurrentSize on rpm.newrelic.com

Status: VERIFIED FIXED

(Core :: Graphics: Layers, defect)

Description

[Ed Morley [:emorley]]

This bug was filed from the Socorro interface and is 
report bp-e2f5a1de-9f7d-47f9-9875-76a282160310.
=============================================================

Reproducible crash using today's x86 Nightly on Windows 10:

1) Visit https://rpm.newrelic.com/accounts/677903/applications/4180461/edit
2) Edit app name
3) Select "Save application settings"
4) A couple of seconds after the page reloads with the "Your application has been updated" banner at the top, crash occurs.

bp-e2f5a1de-9f7d-47f9-9875-76a282160310
bp-256462f5-c7e5-4265-a2c7-3d9c22160310


From about:support...

Name: Firefox
Version: 48.0a1
Build ID: 20160309030419
Update Channel: nightly
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0
OS: Windows_NT 10.0 x86
Multiprocess Windows: 0/1 (Disabled)
Safe Mode: false

Graphics
--------

Adapter Description: NVIDIA Quadro 1000M
Adapter Drivers: nvd3dumx,nvwgf2umx,nvwgf2umx,nvwgf2umx nvd3dum,nvwgf2um,nvwgf2um,nvwgf2um
Adapter RAM: 2048
Asynchronous Pan/Zoom: none
ClearType Parameters: Gamma: 2200 Pixel Structure: R ClearType Level: 100 Enhanced Contrast: 300
Device ID: 0x0dfa
Direct2D Enabled: true
DirectWrite Enabled: true (10.0.10586.0)
Driver Date: 12-3-2015
Driver Version: 10.18.13.5456
GPU #2 Active: false
GPU Accelerated Windows: 1/1 Direct3D 11 (OMTC)
Subsys ID: 21cf17aa
Supports Hardware H264 Decoding: Yes
Vendor ID: 0x10de
WebGL Renderer: Google Inc. -- ANGLE (NVIDIA Quadro 1000M Direct3D11 vs_5_0 ps_5_0)
windowLayerManagerRemote: true
AzureCanvasAccelerated: 0
AzureCanvasBackend: direct2d 1.1
AzureContentBackend: direct2d 1.1
AzureFallbackCanvasBackend: cairo

Comment 1

[Ed Morley [:emorley]]

And some more, though different STR:

bp-9ef553e1-6743-40c8-a826-192152160310
bp-5fe53b69-f88a-4814-94b8-e0bf32160310

1) Open https://papertrailapp.com/
2) Click login link at top right
3) Click papertrail site logo top left to return to the homepage
4) Repeat 2-3 a few times

Comment 2

[Lee Salzman [:lsalzman]]

Seth, looks like it's calling aLayer->GetContainer()->GetCurrentSize(), but GetContainer() is null. Shows you in the log. Want to take a look at this?

Comment 3

[Seth Fowler [:seth] [:s2h]]

Yeah, I will just fix it. The patch is trivial. It's my mistake; I didn't realize that GetContainer() could return null. (Though I should have since the method name included "Get", in retrospect.)

Comment 6

[Seth Fowler [:seth] [:s2h]]

Attachment: Null-check GetContainer() before using it in image-related ConfigureLayer() methods.

The patch is trivial.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

FYI, this has enough crashes to be the #1 topcrash on nightly by a decent margin, except that bug 1255690 beat you to it on the same day, so you're #2.  Would be nice to have this fix in tomorrow's nightly...

The nightly regression window was:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=05c087337043&tochange=af7c0cb0798f
but you already know the regressing bug, so that's not so useful...

Comment 8

[Carsten Book [:Tomcat]]

so is this ready for checkin ? Let me know and i can bring this to m-c to fix the topcrash in the next nightly (also per comment #7)

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I'll land this directly on central (with a=Tomcat via IRC).

Comment 10

[Pulsebot]

https://hg.mozilla.org/mozilla-central/rev/767e0126510e

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/mozilla-central/rev/767e0126510e

Comment 12

[Ed Morley [:emorley]]

Thank you for the quick turnaround on this Seth :-)

Comment 13

[Seth Fowler [:seth] [:s2h]]

(In reply to Ed Morley [:emorley] from comment #12)
> Thank you for the quick turnaround on this Seth :-)

Happy to help. Thanks to Carsten and David for helping to get this landed so fast, and to Markus for reviewing so quickly!

Comment 14

[Cornel Ionce [:noni] [Hubs QA]]

Unable to reproduce this crash anymore on FX 48 beta 2 (build ID 20160620091522) with the STR from description and comment 1 on Windows 10 x64.
Also, no crash reports submitted for the last couple of days. Closing as verified.