1255369 - inIDOMUtils.getCSSValuesForProperty() is missing keywords for 'list-style-type' property

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Sebastian Zartner [:sebo]]

This property is missing all predefined counter styles as well as the 'none' keyword and the symbols() function.

Test case (to execute in Scratchpad):

let DOMUtils = Cc["@mozilla.org/inspector/dom-utils;1"].getService(Ci.inIDOMUtils);

DOMUtils.getCSSValuesForProperty("list-style-type");

Sebastian

Comment 1

[Tom Tromey :tromey]

I solved this one in a bit of an ad hoc way.
Maybe it would be better to introduce an iterator somewhere instead.

Comment 2

[Tom Tromey :tromey]

Attachment: Bug 1255369 - fix getCSSValuesForProperty for line-style-type;

This fixes InspectorUtils::getCSSValuesForProperty to return the
correct values for line-style-type.

Review commit: https://reviewboard.mozilla.org/r/216904/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216904/

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8947132 [details]
Bug 1255369 - fix getCSSValuesForProperty for line-style-type;

https://reviewboard.mozilla.org/r/216904/#review222886

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1fac52e0d5b4
fix getCSSValuesForProperty for line-style-type; r=xidorn

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/1fac52e0d5b4