Open Bug 1254949 Opened 9 years ago Updated 9 months ago

[meta] InspectorUtils::GetCSSValuesForProperty doesn't always return appropriate keywords

Categories

(Core :: CSS Parsing and Computation, defect)

defect

Tracking

()

Tracking Status
firefox48 --- affected

People

(Reporter: sebo, Unassigned)

References

(Depends on 6 open bugs)

Details

(Keywords: meta)

Sometimes it happens that inIDOMUtils.getCSSValuesForProperty() doesn't return all the keyword values valid for a property. This bug is meant as a meta-bug to fix those issues. Sebastian
Depends on: 1254955
Depends on: 1255369
Depends on: 1255373
Depends on: 1255376
Depends on: 1255378
Depends on: 1255379
Depends on: 1255380
Depends on: 1255384
Depends on: 1255385
Depends on: 1255389
Depends on: 1255391
Depends on: 1255397
Depends on: 1255398
Depends on: 1255399
Depends on: 1255400
Depends on: 1255401
Depends on: 1255402
Depends on: 1255403
See Also: → 766032
Derive the data from Servo side may potentially fix many of the issues here, or at least make them easier to fix.
Depends on: 1434130
Severity: normal → S3
Summary: inIDOMUtils.getCSSValuesForProperty() doesn't always return appropriate keywords → [meta] inIDOMUtils.getCSSValuesForProperty() doesn't always return appropriate keywords

(In reply to Xidorn Quan [:xidorn] UTC+11 from comment #1)

Derive the data from Servo side may potentially fix many of the issues here,
or at least make them easier to fix.

This seems to be the case now: https://searchfox.org/mozilla-central/rev/dc08a7321a22918d5a26b7641f9b10cd2a09d98e/layout/inspector/InspectorUtils.cpp#596,601

void InspectorUtils::GetCSSValuesForProperty(GlobalObject& aGlobalObject,
...
  Servo_Property_GetCSSValuesForProperty(&aProperty, &found, &aResult);

Servo_Property_GetCSSValuesForProperty is defined in https://searchfox.org/mozilla-central/rev/dc08a7321a22918d5a26b7641f9b10cd2a09d98e/servo/ports/geckolib/glue.rs#1415-1434

Summary: [meta] inIDOMUtils.getCSSValuesForProperty() doesn't always return appropriate keywords → [meta] InspectorUtils::GetCSSValuesForProperty doesn't always return appropriate keywords
You need to log in before you can comment on or make changes to this bug.