Closed Bug 1255382 Opened 4 years ago Closed 2 years ago

passwordmgr.properties rather confused on android

Categories

(Firefox for Android :: Logins, Passwords and Form Fill, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: Pike, Assigned: zbraniecki)

References

Details

Attachments

(1 file)

I've came across what we're doing with chrome://passwordmgr/locale/passwordmgr.properties on Android, and it's weird.

We're having a double override for that file, 

override chrome://passwordmgr/locale/passwordmgr.properties chrome://browser/locale/overrides/passwordmgr/passwordmgr.properties
override chrome://passwordmgr/locale/passwordmgr.properties chrome://browser/locale/passwordmgr.properties

One from mobile/android/locales/jar.mn, and one from mobile/locales/jar.mn.

It seems that by whatever (chance?) https://dxr.mozilla.org/mozilla-central/source/mobile/android/components/LoginManagerPrompter.js#65 is picking up the one from mobile.

Looking at the files, that shouldn't be using an override for a toolkit file at all?

And I wonder if we need the toolkit one at all?
Blocks: 1255407
Assignee: nobody → gandalf
Status: NEW → ASSIGNED
Attachment #8901623 - Flags: review?(l10n) → feedback?(l10n)
Comment on attachment 8901623 [details]
Bug 1255382 - Detangle passwordmgr.properties in android.

https://reviewboard.mozilla.org/r/173022/#review178516

We'll need a lot of manual work to move this file, we need to coordinate this with flod and mathjazz. See also https://github.com/mozilla-l10n/documentation/blob/master/tools/pontoon/renaming_a_file.md.

The real reason to r- this is that the file should move to mobile/android/locales/en-US/chrome, not mobile/locales... . I try to have as little in mobile/locales as possible. Sounds like we'll be soon able to kill it.
Attachment #8901623 - Flags: review-
Attachment #8901623 - Flags: feedback?(l10n)
Ok, moved the files to mobile/android/locales.

I also reviewed the string use in the file:

used in mobile/android/components/LoginManagerPrompter.js

saveLogin
neverButton
updatePassword
updatePasswordNoUser
updateButton
dontUpdateButton
userSelectText2
passwordChangeTitle

used in mobile/android/components/PromptService.js

username
password

used in both:

rememberButton

duplicated with toolkit's passwordmgr.properties:

userSelectText2
passwordChangeTitle

Not used anywhere:

rememberPassword

===================

I removed the one not used anywhere, moved both files to use chrome://browser/locale/passwordmgr.properties and kept there the duplicated strings because I didn't want to add more logic to LoginManagerPrompt.js to load the toolkit's passwordmgr for them.
Everything works in my manual testing and on try.

NI'ing flod and mathjaz about upcoming string move.
Flags: needinfo?(m)
Flags: needinfo?(francesco.lodolo)
This is mostly on me. After this lands, I need to coordinate with Matjaz to stop syncing, move files, expose new content from m-c to Pontoon.
Flags: needinfo?(m)
Flags: needinfo?(francesco.lodolo)
Comment on attachment 8901623 [details]
Bug 1255382 - Detangle passwordmgr.properties in android.

https://reviewboard.mozilla.org/r/173022/#review179146

Sorry, forgot one more: You'll also need to adjust both filter.py and l10n.toml (aka, three files).

Probably forgot that for the other file, too :-/
Attachment #8901623 - Flags: review?(l10n) → review-
Comment on attachment 8901623 [details]
Bug 1255382 - Detangle passwordmgr.properties in android.

https://reviewboard.mozilla.org/r/173022/#review179148
Attachment #8901623 - Flags: review?(l10n) → review+
Pushed by zbraniecki@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8c39c4756749
Detangle passwordmgr.properties in android. r=Pike
https://hg.mozilla.org/mozilla-central/rev/8c39c4756749
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
You need to log in before you can comment on or make changes to this bug.