1255382 - passwordmgr.properties rather confused on android

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Logins, Passwords and Form Fill, defect)

Description

[Axel Hecht [:Pike]]

I've came across what we're doing with chrome://passwordmgr/locale/passwordmgr.properties on Android, and it's weird.

We're having a double override for that file, 

override chrome://passwordmgr/locale/passwordmgr.properties chrome://browser/locale/overrides/passwordmgr/passwordmgr.properties
override chrome://passwordmgr/locale/passwordmgr.properties chrome://browser/locale/passwordmgr.properties

One from mobile/android/locales/jar.mn, and one from mobile/locales/jar.mn.

It seems that by whatever (chance?) https://dxr.mozilla.org/mozilla-central/source/mobile/android/components/LoginManagerPrompter.js#65 is picking up the one from mobile.

Looking at the files, that shouldn't be using an override for a toolkit file at all?

And I wonder if we need the toolkit one at all?

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1255382 - Detangle passwordmgr.properties in android.

Review commit: https://reviewboard.mozilla.org/r/173022/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/173022/

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 8901623 [details]
Bug 1255382 - Detangle passwordmgr.properties in android.

https://reviewboard.mozilla.org/r/173022/#review178516

We'll need a lot of manual work to move this file, we need to coordinate this with flod and mathjazz. See also https://github.com/mozilla-l10n/documentation/blob/master/tools/pontoon/renaming_a_file.md.

The real reason to r- this is that the file should move to mobile/android/locales/en-US/chrome, not mobile/locales... . I try to have as little in mobile/locales as possible. Sounds like we'll be soon able to kill it.

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

Ok, moved the files to mobile/android/locales.

I also reviewed the string use in the file:

used in mobile/android/components/LoginManagerPrompter.js

saveLogin
neverButton
updatePassword
updatePasswordNoUser
updateButton
dontUpdateButton
userSelectText2
passwordChangeTitle

used in mobile/android/components/PromptService.js

username
password

used in both:

rememberButton

duplicated with toolkit's passwordmgr.properties:

userSelectText2
passwordChangeTitle

Not used anywhere:

rememberPassword

===================

I removed the one not used anywhere, moved both files to use chrome://browser/locale/passwordmgr.properties and kept there the duplicated strings because I didn't want to add more logic to LoginManagerPrompt.js to load the toolkit's passwordmgr for them.

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8901623 [details]
Bug 1255382 - Detangle passwordmgr.properties in android.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/173022/diff/1-2/

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Everything works in my manual testing and on try.

NI'ing flod and mathjaz about upcoming string move.

Comment 6

[Francesco Lodolo [:flod]]

This is mostly on me. After this lands, I need to coordinate with Matjaz to stop syncing, move files, expose new content from m-c to Pontoon.

Comment 7

[Axel Hecht [:Pike]]

Comment on attachment 8901623 [details]
Bug 1255382 - Detangle passwordmgr.properties in android.

https://reviewboard.mozilla.org/r/173022/#review179146

Sorry, forgot one more: You'll also need to adjust both filter.py and l10n.toml (aka, three files).

Probably forgot that for the other file, too :-/

Comment 8

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8901623 [details]
Bug 1255382 - Detangle passwordmgr.properties in android.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/173022/diff/2-3/

Comment 9

[Axel Hecht [:Pike]]

Comment on attachment 8901623 [details]
Bug 1255382 - Detangle passwordmgr.properties in android.

https://reviewboard.mozilla.org/r/173022/#review179148

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c39c4756749
Detangle passwordmgr.properties in android. r=Pike

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/8c39c4756749