Closed Bug 1389397 Opened 2 years ago Closed 2 years ago

Remove the override chrome entries from language manifests (Fennec)

Categories

(Firefox Build System :: Android Studio and Gradle Integration, enhancement)

enhancement
Not set

Tracking

(firefox57 fixed)

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: zbraniecki, Assigned: zbraniecki)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1377911 +++

Similar to bug 1377911 - migrate the locale overrides to chrome in order to not have to create them for each locale/langpack.
Comment on attachment 8896443 [details]
Bug 1389397 - Remove the override chrome entries from language manifests.

https://reviewboard.mozilla.org/r/167686/#review173398

Not sure if the bug 1255382, 1255404 affect us here. At least one of them depended on the order of things to not blow up completely. As you've started picking on the bad overrides on desktop, might be good to pick on these, too.

For now, giving this an r- for the bustage we've seen on desktop.
Attachment #8896443 - Flags: review?(l10n) → review-
Assignee: nobody → gandalf
Status: NEW → ASSIGNED
Ok, let's try. but I'm worried that if fixing those two takes more than a day we'll run into a pickle since the change we did to the repackaging script may cause the override entries to be populated in both en-US and the target locale when repackaging fennec.

If we do repackage fennec we may need this patch landed soon.
Depends on: 1255382, 1255404
Comment on attachment 8896443 [details]
Bug 1389397 - Remove the override chrome entries from language manifests.

https://reviewboard.mozilla.org/r/167686/#review181022

r=me with the comments fixed.

::: mobile/android/locales/jar.mn:6
(Diff revision 2)
>  #filter substitution
>  # This Source Code Form is subject to the terms of the Mozilla Public
>  # License, v. 2.0. If a copy of the MPL was not distributed with this
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
> +# Note: All overrides should go to browser/base/jar.mn in order to avoid

Comment should reference mobile/android/chrome instead of browser/base.

::: mobile/locales/jar.mn:6
(Diff revision 2)
>  #filter substitution
>  # This Source Code Form is subject to the terms of the Mozilla Public
>  # License, v. 2.0. If a copy of the MPL was not distributed with this
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
> +# Note: All overrides should go to browser/base/jar.mn in order to avoid

here, too.
Attachment #8896443 - Flags: review?(l10n) → review+
Pushed by zbraniecki@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/714cf1e91659
Remove the override chrome entries from language manifests. r=Pike
https://hg.mozilla.org/mozilla-central/rev/714cf1e91659
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 57 → mozilla57
You need to log in before you can comment on or make changes to this bug.