1389397 - Remove the override chrome entries from language manifests (Fennec)

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, enhancement)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

+++ This bug was initially created as a clone of Bug #1377911 +++

Similar to bug 1377911 - migrate the locale overrides to chrome in order to not have to create them for each locale/langpack.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1389397 - Remove the override chrome entries from language manifests.

Review commit: https://reviewboard.mozilla.org/r/167686/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/167686/

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 8896443 [details]
Bug 1389397 - Remove the override chrome entries from language manifests.

https://reviewboard.mozilla.org/r/167686/#review173398

Not sure if the bug 1255382, 1255404 affect us here. At least one of them depended on the order of things to not blow up completely. As you've started picking on the bad overrides on desktop, might be good to pick on these, too.

For now, giving this an r- for the bustage we've seen on desktop.

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

Ok, let's try. but I'm worried that if fixing those two takes more than a day we'll run into a pickle since the change we did to the repackaging script may cause the override entries to be populated in both en-US and the target locale when repackaging fennec.

If we do repackage fennec we may need this patch landed soon.

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8896443 [details]
Bug 1389397 - Remove the override chrome entries from language manifests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/167686/diff/1-2/

Comment 5

[Axel Hecht [:Pike]]

Comment on attachment 8896443 [details]
Bug 1389397 - Remove the override chrome entries from language manifests.

https://reviewboard.mozilla.org/r/167686/#review181022

r=me with the comments fixed.

::: mobile/android/locales/jar.mn:6
(Diff revision 2)
>  #filter substitution
>  # This Source Code Form is subject to the terms of the Mozilla Public
>  # License, v. 2.0. If a copy of the MPL was not distributed with this
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
> +# Note: All overrides should go to browser/base/jar.mn in order to avoid

Comment should reference mobile/android/chrome instead of browser/base.

::: mobile/locales/jar.mn:6
(Diff revision 2)
>  #filter substitution
>  # This Source Code Form is subject to the terms of the Mozilla Public
>  # License, v. 2.0. If a copy of the MPL was not distributed with this
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
> +# Note: All overrides should go to browser/base/jar.mn in order to avoid

here, too.

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8896443 [details]
Bug 1389397 - Remove the override chrome entries from language manifests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/167686/diff/2-3/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/714cf1e91659
Remove the override chrome entries from language manifests. r=Pike

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/714cf1e91659