inIDOMUtils.getCSSValuesForProperty() is missing keyword for counter-* properties

VERIFIED FIXED in Firefox 59

Status

()

VERIFIED FIXED
3 years ago
9 months ago

People

(Reporter: sebo, Assigned: tromey)

Tracking

(Blocks: 1 bug)

Trunk
mozilla59
Points:
---

Firefox Tracking Flags

(firefox59 verified)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
The 'counter-increment' and 'counter-reset' properties are missing the 'none' keyword.

Test case (to execute in Scratchpad):

let DOMUtils = Cc["@mozilla.org/inspector/dom-utils;1"].getService(Ci.inIDOMUtils);

let names = ["counter-increment", "counter-reset"];

for (let name of names) {
  console.log(DOMUtils.getCSSValuesForProperty(name));
}

Sebastian
(Assignee)

Updated

a year ago
Assignee: nobody → ttromey
Comment hidden (mozreview-request)
(Assignee)

Comment 2

a year ago
Forgot to rebuild the db after the last change.
Comment hidden (mozreview-request)

Comment 4

a year ago
mozreview-review
Comment on attachment 8941967 [details]
Bug 1255384 - fix getCSSValuesForProperty for counter-*;

https://reviewboard.mozilla.org/r/212152/#review218018
Attachment #8941967 - Flags: review?(cam) → review+
(Assignee)

Comment 5

a year ago
Rebasing.
Comment hidden (mozreview-request)

Comment 7

a year ago
Pushed by ttromey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/de312c964b3a
fix getCSSValuesForProperty for counter-*; r=heycam

Comment 8

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/de312c964b3a
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
(Reporter)

Comment 9

a year ago
Works fine for me on Nightly 2018-01-14. Again, thank you for the patch, Tom!

Sebastian
Status: RESOLVED → VERIFIED
status-firefox59: fixed → verified
status-firefox48: affected → ---
You need to log in before you can comment on or make changes to this bug.