1255384 - inIDOMUtils.getCSSValuesForProperty() is missing keyword for counter-* properties

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Sebastian Zartner [:sebo]]

The 'counter-increment' and 'counter-reset' properties are missing the 'none' keyword.

Test case (to execute in Scratchpad):

let DOMUtils = Cc["@mozilla.org/inspector/dom-utils;1"].getService(Ci.inIDOMUtils);

let names = ["counter-increment", "counter-reset"];

for (let name of names) {
  console.log(DOMUtils.getCSSValuesForProperty(name));
}

Sebastian

Comment 1

[Tom Tromey :tromey]

Attachment: Bug 1255384 - fix getCSSValuesForProperty for counter-*;

This bug notes that getCSSValuesForProperty does not mention the
"none" value for counter-increment and counter-reset.  This fixes the
problem by mentioning the variants in the entries in nsCSSPropList.h.

Review commit: https://reviewboard.mozilla.org/r/212152/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/212152/

Comment 2

[Tom Tromey :tromey]

Forgot to rebuild the db after the last change.

Comment 3

[Tom Tromey :tromey]

Comment on attachment 8941967 [details]
Bug 1255384 - fix getCSSValuesForProperty for counter-*;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/212152/diff/1-2/

Comment 4

[Cameron McCormack (:heycam)]

Comment on attachment 8941967 [details]
Bug 1255384 - fix getCSSValuesForProperty for counter-*;

https://reviewboard.mozilla.org/r/212152/#review218018

Comment 5

[Tom Tromey :tromey]

Rebasing.

Comment 6

[Tom Tromey :tromey]

Comment on attachment 8941967 [details]
Bug 1255384 - fix getCSSValuesForProperty for counter-*;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/212152/diff/2-3/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de312c964b3a
fix getCSSValuesForProperty for counter-*; r=heycam

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/de312c964b3a

Comment 9

[Sebastian Zartner [:sebo]]

Works fine for me on Nightly 2018-01-14. Again, thank you for the patch, Tom!

Sebastian