1255402 - inIDOMUtils.getCSSValuesForProperty() is missing values for 'object-position' and 'perspective-origin'

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Sebastian Zartner [:sebo]]

The 'object-position' and 'perspective-origin' properties are missing their <position> keywords 'top', 'left', 'bottom', 'right' and 'center' as well as the cal() (and -moz-calc()) function.

Test case (to execute in Scratchpad):

let DOMUtils = Cc["@mozilla.org/inspector/dom-utils;1"].getService(Ci.inIDOMUtils);

let names = ["object-position", "perspective-origin"];

for (let name of names) {
  console.log(DOMUtils.getCSSValuesForProperty(name));
}

Sebastian

Comment 1

[Tom Tromey :tromey]

Still missing calc().

Comment 2

[Tom Tromey :tromey]

Attachment: Bug 1255402 - fix getCSSValuesForProperty for object-position and perspective-origin;

getCSSValuesForProperty was not including "calc" for object-position
and perspective-origin.  Fixed by updating the variants in
nsCSSPropList.h.

Review commit: https://reviewboard.mozilla.org/r/213236/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213236/

Comment 3

[Tom Tromey :tromey]

Forgot to update the database, again.

Comment 4

[Tom Tromey :tromey]

Comment on attachment 8942964 [details]
Bug 1255402 - fix getCSSValuesForProperty for object-position and perspective-origin;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/213236/diff/1-2/

Comment 5

[Cameron McCormack (:heycam)]

Comment on attachment 8942964 [details]
Bug 1255402 - fix getCSSValuesForProperty for object-position and perspective-origin;

https://reviewboard.mozilla.org/r/213236/#review219186

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34c24c0414fa
fix getCSSValuesForProperty for object-position and perspective-origin; r=heycam

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/34c24c0414fa

Comment 8

[Sebastian Zartner [:sebo]]

Works for me in 59.0a1 (2018-01-18). Thanks Tom!

Sebastian