Closed Bug 1255813 Opened 4 years ago Closed 4 years ago

Remove build system support for Solaris, HPUX and AIX

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Comment on attachment 8729574 [details]
MozReview Request: Bug 1255813 - Remove build system support for Solaris, HPUX and AIX

https://reviewboard.mozilla.org/r/39515/#review36203

I'm not going to miss any of this junk.

::: build/autoconf/icu.m4:102
(Diff revision 1)
>                  MOZ_ICU_DBG_SUFFIX=
>                  if test -n "$MOZ_DEBUG" -a -z "$MOZ_NO_DEBUG_RTL"; then
>                      MOZ_ICU_DBG_SUFFIX=d
>                  fi
>                  ;;
> -            Darwin|Linux|DragonFly|FreeBSD|NetBSD|OpenBSD|GNU/kFreeBSD|SunOS|Android)
> +            Darwin|Linux|DragonFly|FreeBSD|NetBSD|OpenBSD|GNU/kFreeBSD|Android)

Can you leave this hunk out just to avoid the conflict with my in-flight ICU patches? Most of this file is going away with them anyway.

::: old-configure.in
(Diff revision 1)
>      if test "$LIBRUNPATH"; then
>          DSO_LDOPTS="-R$LIBRUNPATH $DSO_LDOPTS"
>      fi
>      ;;
>  
> -*-solaris*)

I can't say I care *too* much here, but it feels like we could support the Solaris-with-GCC case without too much effort, as most of the junk you're removing is SUNpro support.

Then again, maybe it'd be easier to just add it back in when everything else is in configure.py.
Attachment #8729574 - Flags: review?(ted) → review+
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2)
> Then again, maybe it'd be easier to just add it back in when everything else
> is in configure.py.

That was my thought.
https://hg.mozilla.org/mozilla-central/rev/a960fa1bfffd
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Martin, would this affect Solaris-like support in PkgSrc? Which compiler it's using by default?
Just encountered that Solaris support was removed from Mozilla about year ago.

This is ... so sudden and grievous.

How and why did this happen ? Was there any public discussion ?
(In reply to Konstantin Andreev from comment #7)
> Just encountered that Solaris support was removed from Mozilla about year
> ago.
> 
> This is ... so sudden and grievous.
> 
> How and why did this happen ? Was there any public discussion ?

https://groups.google.com/d/msg/mozilla.dev.platform/9EI8D2jNiEs/Jr0pi4DgBgAJ
(In reply to Konstantin Andreev from comment #7)
> Just encountered that Solaris support was removed from Mozilla about year ago.
> How and why did this happen ? Was there any public discussion ?

(In reply to Mike Hommey [:glandium] from comment #8)
> https://groups.google.com/d/msg/mozilla.dev.platform/9EI8D2jNiEs/Jr0pi4DgBgAJ

Solaris has gone with autoconf. Point taken.

I looked further into the mozilla.dev.platform to clarify how the autoconf was decommissioned, but no luck.

Was there any public discussion about autoconf decommissioning?
(In reply to Konstantin Andreev from comment #9)
> I looked further into the mozilla.dev.platform to clarify how the autoconf
> was decommissioned, but no luck.
> 
> Was there any public discussion about autoconf decommissioning?

Yes, four or five years ago now.  I don't have a link to a formal "we are getting rid of autoconf", but searching for terms like `moz.build` in mozilla.dev.platform may yield positive results.
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.