1255825 - L10n repacks should fail if they're missing strings

Status: NEW

(Firefox Build System :: General, defect)

Description

[Chris AtLee [:catlee]]

(not sure if this is the right component or not - feel free to move somewhere else. build config maybe?)

We hit this in bug 1255811 - some locales ended up with missing strings, and we didn't find out until we were right at the point of shipping.

The repack process should fail if we're expecting to merge in en-US strings, but don't for some reason.

Comment 1

[Axel Hecht [:Pike]]

Yeah, let's say toolkit build config.

Note, I don't have a good idea if this is feasible. We've worked hard to make them unfallible, and now they are.

Related thoughts:

Reducing the pieces that can break might be a good alternative. I filed bug 1255822 ad-hoc, to make us not depend on windows paths and shells. There's the infamous bug 1107635 to get rid of make and put everything into python, too.

Comment 2

[Chris AtLee [:catlee]]

could we make this fatal: https://dxr.mozilla.org/mozilla-central/source/python/mozbuild/mozbuild/jar.py#576 ?

Comment 3

[Axel Hecht [:Pike]]

Right now, compare-locales only creates the merge dir if it actually needs to write to it, so doing so will require us being able to update compare-locales, likely bug 1223385 is required for that.

Comment 4

[Kim Moir [:kmoir] ET]

Triaging an old bucket to be closed - Catlee is this bug still and issue?

Comment 5

[Chris AtLee [:catlee]]

I don't know, Axel is probably a better judge of if this is still a problem.

Comment 6

[Axel Hecht [:Pike]]

With updating compare-locales, the l10n merge directory will become non-optional, so doing something like in comment 2 will become totally feasible.

I'm just preparing a drop in bug 1478343.