Remove media/openmax_dl/dl/Makefile.in

RESOLVED FIXED in Firefox 58

Status

defect
RESOLVED FIXED
3 years ago
Last year

People

(Reporter: ted, Assigned: ted)

Tracking

(Blocks 1 bug)

unspecified
mozilla58
Dependency tree / graph

Firefox Tracking Flags

(firefox58 fixed)

Details

Attachments

(1 attachment)

This Makefile unsets VISIBILITY_FLAGS for Windows builds:
https://hg.mozilla.org/mozilla-central/file/31481f9ebdda792e0ec01d8a007de8b193bc206f/media/openmax_dl/dl/Makefile.in

...but the code only gets built for arm platforms:
https://hg.mozilla.org/mozilla-central/file/31481f9ebdda792e0ec01d8a007de8b193bc206f/media/openmax_dl/dl/moz.build

We should just remove this makefile. While we're there, there's an extraneous moz.build file as well containing nothing but DIRS:
https://hg.mozilla.org/mozilla-central/file/31481f9ebdda792e0ec01d8a007de8b193bc206f/media/openmax_dl/moz.build

We could just make this DIRS line point directly to '/media/openmax_dl/dl/':
https://dxr.mozilla.org/mozilla-central/rev/946ed22cad04431c75ab5093989dfedf1bae5a3e/config/external/moz.build#40
Attachment #8926505 - Flags: review?(core-build-config-reviews)
Comment on attachment 8926505 [details]
bug 1256010 - Remove media/openmax_dl/dl/Makefile.in.

https://reviewboard.mozilla.org/r/197766/#review202962

lgtm.
Attachment #8926505 - Flags: review+
Attachment #8926505 - Flags: review?(core-build-config-reviews)
Assignee: nobody → ted
Pushed by tmielczarek@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2e72bc4c1935
Remove media/openmax_dl/dl/Makefile.in. r=nalexander
https://hg.mozilla.org/mozilla-central/rev/2e72bc4c1935
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.