1256050 - Fix Pocket after deprecating API from ioservice

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1256050_fix_pocket_after_deprecating_API_ioservice.patch

I haven't realized that this.chromeURL is in fact a string a not an nsIURI. I verified that pocket works correctly again.

Comment 2

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8729886 [details] [diff] [review]
bug_1256050_fix_pocket_after_deprecating_API_ioservice.patch

r+ assuming it is working correctly.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Can we get a test for this?

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f31e566af61c

Comment 5

[Christoph Kerschbaumer [:ckerschb]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #3)
> Can we get a test for this?

Shane, it was quite surprising to me as well that we don't have an automated test for Pocket. Any chance you are willing to add one?

Comment 7

[Shane Caraveo (:mixedpuppy)]

(In reply to Christoph Kerschbaumer [:ckerschb] from comment #5)
> (In reply to Ryan VanderMeulen [:RyanVM] from comment #3)
> > Can we get a test for this?
> 
> Shane, it was quite surprising to me as well that we don't have an automated
> test for Pocket. Any chance you are willing to add one?

That is not a simple process.  bug 1235627

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f31e566af61c

Comment 9

[Christoph Kerschbaumer [:ckerschb]]

Ryan, Shane, can we add some kind of test for Pocket? It's a button on the in the right corner on the main user interface of Firefox. I am sorry that I broke it, but we should have at least some kind of test that that is not going to happen again.

Comment 10

[Shane Caraveo (:mixedpuppy)]

per comment 7 need to address bug 1235627