1256163 - Fix all other code styles in webconsole.js

Status: RESOLVED FIXED

(DevTools :: Console, defect, P2)

Comment 1

[Michael Kohler [:mkohler]]

Attachment: 0001-Bug-1256163-Fix-all-other-code-styles-in-webconsole..patch

After this patch, we have fixed all eslint errors in webconsole.js

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 8729985 [details] [diff] [review]
0001-Bug-1256163-Fix-all-other-code-styles-in-webconsole..patch

Review of attachment 8729985 [details] [diff] [review]:
-----------------------------------------------------------------

Redirecting to Lin

Comment 3

[Lin Clark [:linclark]]

Comment on attachment 8729985 [details] [diff] [review]
0001-Bug-1256163-Fix-all-other-code-styles-in-webconsole..patch

Review of attachment 8729985 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch! The fixes look good. The only problem is that we need to change the .eslintignore in a more complicated way. We should still ignore most of the files because they still have errors. You can see that here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6905d671c788&selectedJob=18037160

Comment 4

[Michael Kohler [:mkohler]]

Attachment: 0001-Bug-1256163-Fix-all-other-code-styles-in-webconsole.patch

Thanks for the review. Let's enable the non-test folder once we have fixed the others. Therefore I'm not changing anything on the .eslintignore for now.

Comment 5

[Lin Clark [:linclark]]

Awesome! I'm just putting it through one more try push (this time actually running the tests) to make sure we haven't broken anything. If that shows up green, then this is good to go.

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2aff3a4be2d0

Comment 6

[Lin Clark [:linclark]]

Comment on attachment 8730902 [details] [diff] [review]
0001-Bug-1256163-Fix-all-other-code-styles-in-webconsole.patch

Review of attachment 8730902 [details] [diff] [review]:
-----------------------------------------------------------------

It looks like this is failing one of the tests: devtools/client/webconsole/test/browser_webconsole_bug_782653_CSS_links_in_Style_Editor.js

I didn't get a chance to look into where the test is failing, so there's a chance it's something obscure. Ping if you have any trouble diagnosing it.

Comment 7

[Michael Kohler [:mkohler]]

Attachment: webconsole.patch

This now doesn't break the test at least locally. Unfortunately I still can't push to try.

Comment 8

[Michael Kohler [:mkohler]]

Attachment: webconsole.patch (incl. commit message)

Comment 9

[Michael Kohler [:mkohler]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=430a8c3f28c7

Comment 10

[Lin Clark [:linclark]]

Comment on attachment 8731512 [details] [diff] [review]
webconsole.patch (incl. commit message)

Review of attachment 8731512 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! Glad the try issue got sorted.

The oranges in there look like unrelated intermittents to me, so I think this one's ready to go!

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/69f41452a4d1

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/69f41452a4d1