1256246 - Change prompt for selecting a directory when loading a temporary add-on

Status: RESOLVED FIXED

(DevTools :: about:debugging, defect)

Description

[Kumar McMillan [:kumar]]

As a quick workaround to bug 1249315, explain how you have to select a file (not a directory) in the load temporary add-on picker.

Maybe changing https://mxr.mozilla.org/mozilla-central/source/devtools/client/locales/en-US/aboutdebugging.properties#8 to say "Select manifest.json or XPI File" would make it easier for the user.

Comment 1

[Kumar McMillan [:kumar]]

Attachment: MozReview Request: bug 1256246 - Improve prompt for loading an add-on from directory. r?ochameau

Review commit: https://reviewboard.mozilla.org/r/39687/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39687/

Comment 2

[Alexandre Poirot [:ochameau]]

Comment on attachment 8730143 [details]
MozReview Request: bug 1256246 - Improve prompt for loading an add-on from directory. r?ochameau

https://reviewboard.mozilla.org/r/39687/#review36363

::: devtools/client/locales/en-US/aboutdebugging.properties:15
(Diff revision 1)
>  addonDebugging.label = Enable add-on debugging
>  addonDebugging.tooltip = Turning this on will allow you to debug add-ons and various other parts of the browser chrome
>  addonDebugging.moreInfo = more info
>  loadTemporaryAddon = Load Temporary Add-on
>  extensions = Extensions
> -selectAddonFromFile = Select Add-on Directory or XPI File
> +selectAddonFromFile = Select Manifest File or XPI File

Ok, so we still have to do this. Change the property key name if we update the value...
https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings

So please use selectAddonFromFile2 and update that in code here:
http://mxr.mozilla.org/mozilla-central/source/devtools/client/aboutdebugging/components/addons-controls.js#63

Wouldn't it be better to phrase it to:
  Select Manifest or XPI File

Also, is XPI File that clear?
  Select Manifest File or Package (.xpi)

Comment 3

[Kumar McMillan [:kumar]]

Comment on attachment 8730143 [details]
MozReview Request: bug 1256246 - Improve prompt for loading an add-on from directory. r?ochameau

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/39687/diff/1-2/

Comment 4

[Kumar McMillan [:kumar]]

Comment on attachment 8730143 [details]
MozReview Request: bug 1256246 - Improve prompt for loading an add-on from directory. r?ochameau

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/39687/diff/2-3/

Comment 5

[Kumar McMillan [:kumar]]

https://reviewboard.mozilla.org/r/39687/#review36363

> Ok, so we still have to do this. Change the property key name if we update the value...
> https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings
> 
> So please use selectAddonFromFile2 and update that in code here:
> http://mxr.mozilla.org/mozilla-central/source/devtools/client/aboutdebugging/components/addons-controls.js#63
> 
> Wouldn't it be better to phrase it to:
>   Select Manifest or XPI File
> 
> Also, is XPI File that clear?
>   Select Manifest File or Package (.xpi)

yes, I like this one the best, 'Select Manifest File or Package (.xpi)', because it is clear that the manifest is a file and that the package is a .xpi file.

Comment 6

[Kumar McMillan [:kumar]]

https://reviewboard.mozilla.org/r/39685/#review36383

I've made the small changes requested

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/4dfa6cdb7faa

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4dfa6cdb7faa