Closed Bug 1256307 Opened 8 years ago Closed 8 years ago

Only print via the parent in Nightly until sandboxing rides the trains.

Categories

(Core :: Printing: Output, defect)

47 Branch
All
Windows
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox47 --- fixed
firefox48 --- fixed

People

(Reporter: bobowen, Assigned: bobowen)

References

Details

Attachments

(1 file)

Printing via the parent breaks printing with print.always_print_silent=true completely, so we're going to turn it off until that's fixed as we're only sandboxing content in Nightly at the moment anyway.
Attachment #8730202 - Flags: review?(jmathies)
Attachment #8730202 - Flags: review?(jmathies) → review+
https://hg.mozilla.org/mozilla-central/rev/72cf6912e30a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Comment on attachment 8730202 [details] [diff] [review]
Only print via the parent in Nightly

Approval Request Comment
[Feature/regressing bug #]:
Bug 1156742.

[User impact if declined]:
Pref - print.always_print_silent=true will cause printing to fail.

[Describe test coverage new/current, TreeHerder]:
There is no automated testing for printing, but this just turns off the pref to print via the parent, which is the same setting as in Beta.

[Risks and why]: 
Low - just a pref change.

[String/UUID change made/needed]:
None
Attachment #8730202 - Flags: approval-mozilla-aurora?
Hi Bob, if this is Nightly only, why are we requesting uplift to Aurora47? Just wondering.
Flags: needinfo?(bobowen.code)
(In reply to Ritu Kothari (:ritu) from comment #5)
> Hi Bob, if this is Nightly only, why are we requesting uplift to Aurora47?
> Just wondering.

Because in Aurora47 it is currently not set to Nightly only and so is turned on.
There are regressions that it is causing, one minor and one possibly more serious that was reported yesterday.
Flags: needinfo?(bobowen.code)
(In reply to Bob Owen (:bobowen) (PTO back 1st Apr) from comment #6)
> (In reply to Ritu Kothari (:ritu) from comment #5)
> > Hi Bob, if this is Nightly only, why are we requesting uplift to Aurora47?
> > Just wondering.
> 
> Because in Aurora47 it is currently not set to Nightly only and so is turned
> on.
> There are regressions that it is causing, one minor and one possibly more
> serious that was reported yesterday.

Duh! Got it. Thanks!
Comment on attachment 8730202 [details] [diff] [review]
Only print via the parent in Nightly

regression, Aurora47+
Attachment #8730202 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Blocks: 1270447
No longer blocks: 1255336
You need to log in before you can comment on or make changes to this bug.