Closed
Bug 1256399
Opened 8 years ago
Closed 8 years ago
Refactor tests in toolkit/mozapps/update/tests/chrome to use signed xpi's rather than generated ones
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
RESOLVED
FIXED
mozilla47
People
(Reporter: ahal, Assigned: aswan)
References
Details
Attachments
(1 file)
https://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/update/tests/chrome/utils.js#178 These tests are using some addons that are zipped and generated on the fly in utils.js. They likely got missed initially because they are generated programmatically at test runtime (not as part of the build). They'll likely need to be checked in statically rather than generated on the fly. Alternatively these could be installed temporarily, but I have a hunch that would invalidate what they're supposed to be testing.
Updated•8 years ago
|
Assignee: nobody → aswan
Comment 1•8 years ago
|
||
Looks like the best bet is to load them temporarily, aswan is going to take a look. Somewhere around here: https://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/update/tests/chrome/utils.js#1319
Assignee | ||
Comment 2•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=386330bc1945
Assignee | ||
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/40089/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/40089/
Attachment #8730686 -
Flags: review?(dtownsend)
Updated•8 years ago
|
Attachment #8730686 -
Flags: review?(dtownsend) → review+
Comment 4•8 years ago
|
||
Comment on attachment 8730686 [details] MozReview Request: Bug 1256399 use temporary addon installation for update tests r?mossop https://reviewboard.mozilla.org/r/40089/#review36967 Well this works for now but will break as soon as we fix bug 1257213.
Assignee | ||
Comment 5•8 years ago
|
||
Ah. We could have a flag to un-skip temporary addons that we just use for the test? Anyhow, I guess we cross that bridge when we come to it...
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 8•8 years ago
|
||
backed this out for timeouts like https://treeherder.mozilla.org/logviewer.html#?job_id=8079817&repo=fx-team
Flags: needinfo?(aswan)
Assignee | ||
Comment 9•8 years ago
|
||
Comment on attachment 8730686 [details] MozReview Request: Bug 1256399 use temporary addon installation for update tests r?mossop Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40089/diff/1-2/
Assignee | ||
Comment 10•8 years ago
|
||
Just pushed a fix that I think should work. Unfortunately I'm about to disappear for a day for travel, ni to mossop to land this in my absence assuming the try job looks good.
Flags: needinfo?(aswan) → needinfo?(dtownsend)
Comment 12•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/fef5ea8968cb
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•8 years ago
|
Flags: needinfo?(dtownsend)
Assignee | ||
Comment 13•8 years ago
|
||
Comment on attachment 8730686 [details] MozReview Request: Bug 1256399 use temporary addon installation for update tests r?mossop Approval Request Comment [Feature/regressing bug #]: Bug 1256399 [User impact if declined]: No direct user impact, this a test-only change [Describe test coverage new/current, TreeHerder]: N/A, this patch changes test logic so that update tests can pass with or without addon signing enabled. [Risks and why]: This is blocking bug 1186522 (enabling addon signing by default in all automated testing). Risks are minimal since it is a test-only change. [String/UUID change made/needed]: none
Attachment #8730686 -
Flags: approval-mozilla-beta?
status-firefox47:
--- → affected
Comment on attachment 8730686 [details] MozReview Request: Bug 1256399 use temporary addon installation for update tests r?mossop Hello Andrew, test-only changes are auto-approved and do not need review by release management team.
Flags: needinfo?(aswan)
Attachment #8730686 -
Flags: approval-mozilla-beta?
Assignee | ||
Comment 16•8 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/327f08cfe26a
You need to log in
before you can comment on or make changes to this bug.
Description
•