Closed
Bug 1256432
Opened 9 years ago
Closed 9 years ago
Unfork account.xml
Categories
(Chat Core :: General, defect)
Chat Core
General
Tracking
(Not tracked)
RESOLVED
FIXED
Instantbird 48
People
(Reporter: aleth, Assigned: aleth)
References
Details
Attachments
(2 files, 1 obsolete file)
|
22.66 KB,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
|
11.22 KB,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
I wanted to add bug 955413 to TB as well and noticed this file is pointlessly forked (the only differences are a bugfix that is missing in TB and a single line of code).
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → aleth
Status: NEW → ASSIGNED
|
||
Updated•9 years ago
|
Attachment #8730405 -
Flags: review?(clokep) → review+
|
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8730406 [details] [diff] [review] Unfork accounts.dtd Review of attachment 8730406 [details] [diff] [review]: ----------------------------------------------------------------- ::: chat/locales/en-US/accounts.dtd @@ +7,4 @@ > <!ENTITY accountManager.width "450"> > +<!-- Account manager window for Thunderbird --> > +<!ENTITY accountsWindow.title "Instant messaging status"> > +<!ENTITY accountsWindow2.style "width: 41em; height: 27em;"> I'd like Florian's opinion on this.
Attachment #8730406 -
Flags: review?(florian)
Attachment #8730406 -
Flags: review?(clokep)
Attachment #8730406 -
Flags: review+
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8730405 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8730405 -
Attachment is obsolete: false
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8730406 -
Attachment is obsolete: true
Attachment #8730406 -
Flags: review?(florian)
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8730422 [details] [diff] [review] Unfork accounts.dtd Review of attachment 8730422 [details] [diff] [review]: ----------------------------------------------------------------- ::: chat/locales/en-US/accounts.dtd @@ +15,5 @@ > <!ENTITY accountManager.close.accesskey "l"> > <!-- This should match account.commandkey in instantbird.dtd --> > <!ENTITY accountManager.close.commandkey "a"> > <!-- This title must be short, displayed with a big font size --> > +<!ENTITY accountManager.noAccount.title "No account configured yet"> I'm not sure what the point of this change is, but it's fine with me either way.
Attachment #8730422 -
Flags: review?(florian) → review+
|
|
Assignee | |
Comment 6•9 years ago
|
||
(In reply to Florian Quèze [:florian] [:flo] from comment #5) > > <!-- This title must be short, displayed with a big font size --> > > +<!ENTITY accountManager.noAccount.title "No account configured yet"> > > I'm not sure what the point of this change is, but it's fine with me either > way. There's no point, that's just the version of the string from TB.
|
|
Assignee | |
Comment 7•9 years ago
|
||
https://hg.mozilla.org/comm-central/rev/d9cc74deecf621f5e20b701080dc69e7d8564dc2 Bug 1256432 - Unfork account.xml. r=clokep https://hg.mozilla.org/comm-central/rev/e082a51dfcd01ca4c873b77b12209109fe9febaf Bug 1256432 - Unfork accounts.dtd. r=clokep
|
|
Assignee | |
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Instantbird 48
You need to log in
before you can comment on or make changes to this bug.
Description
•