1256485 - Remove initial_data fixture from the unit tests

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[William Lachance (:wlach)]

It behaves incorrectly, overwriting the temporary "test" repository we create for treeherder (we didn't notice only because the jobs model keeps a cache of the test db name around, even though it's gone). This is interfering with my efforts to get rid of the last of refdata model. Almost no tests require anything from it, so we're best off just doing without it IMO.

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] wlach:1256485 > mozilla:master

Comment 2

[William Lachance (:wlach)]

Comment on attachment 8730444 [details] [review]
[treeherder] wlach:1256485 > mozilla:master

I think this one is pretty straightforward. :P

Comment 3

[William Lachance (:wlach)]

Comment on attachment 8730444 [details] [review]
[treeherder] wlach:1256485 > mozilla:master

mdoglio is away

Comment 4

[Ed Morley [:emorley]]

Comment on attachment 8730444 [details] [review]
[treeherder] wlach:1256485 > mozilla:master

Looks great - thank you for doing this :-)

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/ecac73e26a409daacc6b79de7ef4506870406beb
Bug 1256485 - Don't load initial data in unit tests

It's almost entirely unnecessary (the few times we need base data
we can generate it ourselves) and can overwrite other test data
if we're not careful. Better just to remove it.