Closed Bug 1231361 Opened 9 years ago Closed 9 years ago

Use the django orm instead of RefDataModel

Categories

(Tree Management :: Treeherder: Data Ingestion, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mdoglio, Assigned: wlach)

References

Details

Attachments

(6 files)

Using RefDataModel is not necessary anymore, let's get rid of it.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
Bug 1239185 won't remove the refdatamodel altogether, just some (most) of it.
Status: RESOLVED → REOPENED
Depends on: 1239185
Resolution: DUPLICATE → ---
Depends on: 1256485
Comment on attachment 8736477 [details] [review] [treeherder] wlach:1231361 > mozilla:master I figured I'd split the remaining work on this bug into smaller chunks so it's easier for people to review incrementally, instead of doing a monster patch. Cam, could you take a quick look at this? It's pretty much just one big piece of code deletion.
Attachment #8736477 - Flags: review?(cdawson)
Attachment #8736477 - Flags: review?(cdawson) → review+
Comment on attachment 8737516 [details] [review] [treeherder] wlach:1231361-2 > mozilla:master Hey Ed, do you want to take a look at this? I tried to just make this a straight refactoring, there's lots I noticed that could be improved/changed but I tried to keep my eye on the prize of removing datasource. ;)
Attachment #8737516 - Flags: review?(emorley)
Comment on attachment 8737952 [details] [review] [treeherder] mozilla:onhold-repo-fix > mozilla:master For your reading pleasure, sir. :)
Attachment #8737952 - Flags: review?(wlachance)
Attachment #8737952 - Flags: review?(wlachance) → review+
Comment on attachment 8737516 [details] [review] [treeherder] wlach:1231361-2 > mozilla:master Looks great - nice work! :-)
Attachment #8737516 - Flags: review?(emorley) → review+
Commits pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/15ba5b10b94ce89cc6d11c092b9dacc14e061acf Bug 1231361 - Remove bugscache methods from refdata model Instead, just use the ORM directly where needed. https://github.com/mozilla/treeherder/commit/649e6bfcabf9d6d93c70118b7d595e0585af7a6c Bug 1231361 - Remove reference data signature methods from refdata model https://github.com/mozilla/treeherder/commit/ea0697b13504953f9df5d52c4116d3e400caad8b Bug 1231361 - Remove option collection method from refdata model https://github.com/mozilla/treeherder/commit/92f02ccc25b0c6ae8c81686f8af22d713be9dc11 Bug 1231361 - Remove refdata model dependency from unit tests https://github.com/mozilla/treeherder/commit/5e24106af844b1a38452b951a4ca8925a18c0274 Bug 1231361 - Remove the last of the refdata model The only thing we were still using it for was to get a database name, which we can just as easily grab from settings. https://github.com/mozilla/treeherder/commit/53420b81910a4e82770c0605181227ccc6750065 Merge pull request #1385 from wlach/1231361-2 Bug 1231361 - Remove last of refdata model
Goodbye refdata model, we hardly knew ye.
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
Blocks: 1178641
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/fce6c1c342bb196303ae023fe18239df1c848209 Bug 1231361 - Fix performance artifact ingestion We weren't taking the repository into account when getting the reference data signature.
Depends on: 1264212
Assignee: nobody → wlachance
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: