Closed Bug 1256613 Opened 8 years ago Closed 8 years ago

[TV] TV FTU needs UI polish

Categories

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::First Time Experience
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.5+, b2g-v2.5 fixed, b2g-master fixed)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g 2.5+
Tracking Flags:
Tracking Status
b2g-v2.5 --- fixed
b2g-master --- fixed

People

(Reporter: Fischer, Assigned: Fischer)

Details

(Whiteboard: [ft:conndevices][partner-cherry-pick][partner-blocker])

Attachments

(2 files)

[gaia] Fischer-L:bug_1256613-tv-ftu-UI-polish > mozilla-b2g:master
46 bytes, text/x-github-pull-request
rexboy
: review+
jocheng
: approval-gaia-v2.5+
Details | Review
[gaia] Fischer-L:bug_1256613-v2.5 > mozilla-b2g:v2.5
46 bytes, text/x-github-pull-request
Details | Review 
Need to polish TV FTU style for TV:
* Enlarge the arrow icon size
* Enlarge the link size when focused
* Adjust margins between paragraphs
* Adjust the horizontal scrollbar rule
Assignee: nobody → fliu
Whiteboard: [ft:conndevices][partner-cherry-pick][partner-blocker]
[Blocking Requested - why for this release]:
blocking-b2g: --- → 2.5?
It's better that visual or ux spec also update too. Otherwise QA team will feel confused.
blocking-b2g: 2.5? → 2.5+
Flags: needinfo?(jalin)
Blocks: 1257442
No longer blocks: 1257442
Update the style changes:
- Enlarge the link size when focused
- Adjust margins between paragraphs
- Adjust the horizontal scrollbar rule

The arrow icon has to do animation so deal in the bug 1257442.
Comment on attachment 8732038 [details] [review]
[gaia] Fischer-L:bug_1256613-tv-ftu-UI-polish > mozilla-b2g:master

@Rex,

This patch:
- Enlarge the link size when focused
- Adjust margins between paragraphs
- Adjust the horizontal scrollbar rule

Thanks
Attachment #8732038 - Flags: review?(rexboy)
Comment on attachment 8732038 [details] [review]
[gaia] Fischer-L:bug_1256613-tv-ftu-UI-polish > mozilla-b2g:master

Looks good.
Attachment #8732038 - Flags: review?(rexboy) → review+
Fischer, I didn't see UX/visual spec updated on this bug. Without formal spec update, you can't land any code here. Otherwise our QA team will feel confuse and report bugs again and again.
Dear all,

The spec have been updated. Please refer to the links as below,

UX spec:
https://drive.google.com/open?id=0BwbmH5cX2W6OMEo0cUVXN251Mmc

UI spec:
https://drive.google.com/a/mozilla.com/file/d/0B4K8q1qWmtAvajByLUtod0JlTG8/view

Thank you very much
Jack
Flags: needinfo?(jalin)
Dear all,

Please refer to v2.5 spec as the links below,

UX spec:
https://drive.google.com/open?id=0BwbmH5cX2W6OMEo0cUVXN251Mmc

UI spec:
https://drive.google.com/open?id=0B4K8q1qWmtAvV2lqTXMwY0ZySFk
(Updated UI spec: We use Panasonic scroll bar for TV v2.5.)

Thank you very much
Jack
Land to Master: https://github.com/mozilla-b2g/gaia/commit/5f122a78b9186c66f08065d09429ccdb5e7799e3
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Comment on attachment 8732038 [details] [review]
[gaia] Fischer-L:bug_1256613-tv-ftu-UI-polish > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):1256613
[User impact] if declined: The UI is not balanced on real TV
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]: No
Attachment #8732038 - Flags: approval-gaia-v2.5?(jocheng)
Comment on attachment 8732038 [details] [review]
[gaia] Fischer-L:bug_1256613-tv-ftu-UI-polish > mozilla-b2g:master

Approve for TV 2.5
Attachment #8732038 - Flags: approval-gaia-v2.5?(jocheng) → approval-gaia-v2.5+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: