1256615 - Nightly icon disappeared upon update

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Karen Rudnitski [:kar]]

Logging this just in case anyone has seen this.

I have Nightly in my bottom home dock. It's been a while since I updated it - looks like I upgraded from a version of 46 to last night's nightly.

Everything went as per normal, I accepted the additional permission, and then once done, the icon was no longer in my home dock. It's in the app grid, but why did it disappear from my home dock?

I'm raising this to ensure this doesn't happen later on (ie in our release channel!).

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

nalexander: I think we have talked about this before (maybe when the bouncer was in development and we moved manifest things around?) but I can't find a bug about it. Just today my Aurora icon disappeared from my home screen and I'm afraid that this is a bug that's currently riding the trains. Did we ever research this?

Comment 2

[Nick Alexander :nalexander [he/him]]

(In reply to Sebastian Kaspari (:sebastian) from comment #1)
> nalexander: I think we have talked about this before (maybe when the bouncer
> was in development and we moved manifest things around?) but I can't find a
> bug about it. Just today my Aurora icon disappeared from my home screen and
> I'm afraid that this is a bug that's currently riding the trains. Did we
> ever research this?

Ah, I think I know why this is, and it should be no later than Aurora.  It's fallout from Bug 1242213, which I will have to address.

Comment 3

[:Margaret Leibovic]

Did all of the patches for bug 1242213 bounce from 47? If so, we can re-nom this to not track 47.

But setting it to 47 for now to be safe.

Comment 4

[Nick Alexander :nalexander [he/him]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8f4e1321da47

Comment 5

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: Bug 1256615 - Partially restore removed <activity-alias>. r?sebastian

Bug 1242213 removed the entire <activity-alias>.  Sadly, users who
added the Firefox icon to their dock (for example, Samsung's Touchwiz
dock) will see the icon disappear when they upgrade, because the
intent filter disappears.  (That is, the icon is connected to .App and
action MAIN, not to the package and action MAIN.)

This patch restores the .App <activity-alias> for action MAIN.  It
doesn't add the launcher and other categories, which could lead to
multiple launcher icons.  New users that add the Firefox icon to their
dock will use .BrowserApp, but sadly we'll need to maintain this alias
essentially forever to support existing dock icons.

Review commit: https://reviewboard.mozilla.org/r/41571/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/41571/

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8733119 [details]
MozReview Request: Bug 1256615 - Partially restore removed <activity-alias>. r?sebastian

https://reviewboard.mozilla.org/r/41571/#review38117

Comment 7

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/ecf81bf18bdf7939aa0e70e698c40dbcb9dcb7b4
Bug 1256615 - Partially restore removed <activity-alias>. r=sebastian

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ecf81bf18bdf

Comment 9

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8733119 [details]
MozReview Request: Bug 1256615 - Partially restore removed <activity-alias>. r?sebastian

Approval Request Comment
[Feature/regressing bug #]: Bug 1242213

[User impact if declined]: Users who have moved the Firefox icon into their homescreen docks (which is not a precise concept on Android, but includes Samsung Touchwiz and Google's launcher docks) will see the icon silently disappear.

[Describe test coverage new/current, TreeHerder]: tested manually with a local build.  Tested by:

1) installing pre-Bug 1242213 Nightly from http://ftp.mozilla.org/pub/mobile/nightly/2016/02/2016-02-01-03-02-41-mozilla-central-android-api-15/fennec-47.0a1.multi.android-arm.apk

2) dragging Nightly icon into dock

3) installing post-Bug 1242213 Nightly from http://ftp.mozilla.org/pub/mobile/nightly/2016/02/2016-02-11-03-02-42-mozilla-central-android-api-15/fennec-47.0a1.multi.android-arm.apk

4) observing Nightly icon disappear from dock

5) installing pre-Bug 1242213 Nightly from http://ftp.mozilla.org/pub/mobile/nightly/2016/02/2016-02-01-03-02-41-mozilla-central-android-api-15/fennec-47.0a1.multi.android-arm.apk

6) re-dragging Nightly icon into dock

7) installing post-Bug 1242213 and post-Bug 1256615 Nightly from http://ftp.mozilla.org/pub/mobile/nightly/2016/03/2016-03-24-03-04-47-mozilla-central-android-api-15/fennec-48.0a1.multi.android-arm.apk

8) observing Nightly icon remains in dock

[Risks and why]:  Very low.  This is a partial backout of an earlier patch.

[String/UUID change made/needed]: none.

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8733119 [details]
MozReview Request: Bug 1256615 - Partially restore removed <activity-alias>. r?sebastian

Manually verified and a recent regression, Aurora47+

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8996aca3a005

Comment 12

[Sebastian Kaspari (:sebastian; :pocmo)]

I just filed bug 1268455. This has happened with the Beta 47 release again: The Firefox beta icon disappeared from my home screen. It seems like this bug is still riding the trains somehow :(