Beta icon disappeared from home screen upon update (47.0)

VERIFIED FIXED in Firefox 47

Status

()

--
critical
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: sebastian, Assigned: sebastian)

Tracking

unspecified
Firefox 49
All
Android
Points:
---

Firefox Tracking Flags

(firefox46 wontfix, firefox47+ verified, firefox48+ verified, firefox49 verified, fennec47+)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
History: bug 1256615 (Icon disappeared after Nightly/Aurora update)

With the release of Firefox Beta 47.0 the icon disappeared from my home screen. I wonder why we see this again because this should have been fixed in bug 1256615. We only have one release left to get this right. Otherwise we remove ourselves from all home screens with the release of 47.. :(
(Assignee)

Comment 1

3 years ago
It might even make sense to not release 47.0 in 6 weeks until we have manually verified that this is fixed with the release build that we are going to upload to google play.
Reproduced on my N6P with Android 6.0
(Assignee)

Updated

3 years ago
Duplicate of this bug: 1268507
(Assignee)

Comment 4

3 years ago
According to bug 1268507 the widget got removed too.
[Tracking Requested - why for this release]: we can't afford to remove the homescreen shortcut
tracking-fennec: ? → 47+
tracking-firefox47: --- → ?
Folks, I'm sorry for this pain.  According to https://dxr.mozilla.org/mozilla-beta/source/mobile/android/base/AndroidManifest.xml.in#147, the fix should be in the build.

I can only imagine that this isn't sufficient.  (Potentially only on some devices?  It could be launcher specific, but I thought .App would cover them all.)

I think it's still an option to revert the entire <activity-alias>, although I can't investigate it myself.
The next time we think we fix this, we should make sure to get QA to verify this update flow thoroughly. 

Sebastian, can you take this on?
Assignee: nobody → s.kaspari
Flags: needinfo?(s.kaspari)
(Assignee)

Comment 9

3 years ago
I'll look into it.
Status: NEW → ASSIGNED
Flags: needinfo?(s.kaspari)
(Assignee)

Comment 10

3 years ago
Regression: https://hg.mozilla.org/mozilla-central/rev/92227c8d185b
Fix on Aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/8996aca3a005

The original activity-alias had more intent filter categories that are now attached to the activity. Maybe that's it. I'll prepare something to test that.

Fixing this and releasing the fix might potentially remove the nightly/aurora/beta icon again. But well, better than removing the release icon.
Sounds like this will affect 48+ once it moves to beta. tracking and marking affected. If we get a fix we may want to uplift it to beta.
status-firefox48: --- → affected
tracking-firefox47: ? → +
tracking-firefox48: --- → +
status-firefox46: --- → wontfix
(Assignee)

Comment 12

3 years ago
I can reproduce this by installing 46.0b13, creating a home screen shortcut and then updating to 47.0b1. If a patch lands in beta we can test this by upgrading from 46.0b13 to the new beta version 47.0bX. The icon should not disappear.
(Assignee)

Comment 13

3 years ago
Created attachment 8748101 [details]
MozReview Request: Bug 1268455 - Restore <activity-alias> to avoid disappearing home screen shortcuts. r?margaret

This patch restores our previous <activity-alias> with all intent filters. Changing the alias
will cause that existing home screen shortcuts disappear.

I tested this patch with:
* Upgrading old state (2016-02-06) to current state: Icon disappears (expected)
* Upgrading old state to fixed state (this patch): Icon remains

As this patch changes the activity-alias again, releasing this patch will lead to the home
screen shortcut disappearing once more for all released version with the current state:
* Upgrading current state to fixed state: Icon disappears (expected)

Review commit: https://reviewboard.mozilla.org/r/50155/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/50155/
Attachment #8748101 - Flags: review?(margaret.leibovic)
(Assignee)

Comment 14

3 years ago
(In reply to Sebastian Kaspari (:sebastian) from comment #13)
> As this patch changes the activity-alias again, releasing this patch will
> lead to the home
> screen shortcut disappearing once more for all released version with the
> current state:
> * Upgrading current state to fixed state: Icon disappears (expected)

This is important and we need to remember this if bug reports are coming in after releasing the patch on Nightly/Aurora/Beta.
(In reply to Sebastian Kaspari (:sebastian) from comment #14)
> (In reply to Sebastian Kaspari (:sebastian) from comment #13)
> > As this patch changes the activity-alias again, releasing this patch will
> > lead to the home
> > screen shortcut disappearing once more for all released version with the
> > current state:
> > * Upgrading current state to fixed state: Icon disappears (expected)
> 
> This is important and we need to remember this if bug reports are coming in
> after releasing the patch on Nightly/Aurora/Beta.

This merits a mobile-firefox-dev post when we land this bug.
Comment on attachment 8748101 [details]
MozReview Request: Bug 1268455 - Restore <activity-alias> to avoid disappearing home screen shortcuts. r?margaret

https://reviewboard.mozilla.org/r/50155/#review47063
Attachment #8748101 - Flags: review?(margaret.leibovic) → review+
See Also: → bug 1270101
(Assignee)

Comment 17

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/a9e926a9b3365fc018904771ae7e9271e10688dc
Bug 1268455 - Restore <activity-alias> to avoid disappearing home screen shortcuts. r=margaret
(Assignee)

Comment 18

3 years ago
Comment on attachment 8748101 [details]
MozReview Request: Bug 1268455 - Restore <activity-alias> to avoid disappearing home screen shortcuts. r?margaret

Approval Request Comment

[Feature/regressing bug #]: Regression from bug 1242213.

[User impact if declined]: Launcher icon will disappear from home screens after updating to version 47.0. This already happened in Nightly, Aurora and Beta.

[Describe test coverage new/current, TreeHerder]: Manual testing with the different app versions, see comment 13.

[Risks and why]: Risk is low: We are restoring the previous manifest entry. A side effect of this patch is that users who are already on 47+ will see their launcher icons disappear once more.

[String/UUID change made/needed]: -
Attachment #8748101 - Flags: approval-mozilla-beta?
Attachment #8748101 - Flags: approval-mozilla-aurora?
Comment on attachment 8748101 [details]
MozReview Request: Bug 1268455 - Restore <activity-alias> to avoid disappearing home screen shortcuts. r?margaret

This is a critical recent regression, Aurora48+, Beta47+
Attachment #8748101 - Flags: approval-mozilla-beta?
Attachment #8748101 - Flags: approval-mozilla-beta+
Attachment #8748101 - Flags: approval-mozilla-aurora?
Attachment #8748101 - Flags: approval-mozilla-aurora+
Hi Ioana, Florin: I am surprised we did not catch this regression in our Fennec Beta47 sign offs. Could you please add this to the Beta sign off test plan? Also, could you please verify this issue is fixed as expected on a latest Beta build? Thanks!
Flags: needinfo?(florin.mezei)
Flags: needinfo?(chiorean.ioana)

Comment 21

3 years ago
Hi Ritu 
In the SignOff process we can not test the update as the build is not on the Google Play. We used to test this with the updates checks that we made after the build reached the store ( my second mail) but there was a discussion on the rel drivers list about this being not a helpful activity and we stopped doing it. 

We will check it with Beta 4. We can also retake the SignOff process for updates.
Flags: needinfo?(ioana.chiorean)
Flags: needinfo?(florin.mezei)
Flags: needinfo?(chiorean.ioana)

Comment 22

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a9e926a9b336
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49

Comment 23

3 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/4c5959b81fd5
status-firefox48: affected → fixed
status-firefox47: affected → fixed
It happened to me on nightly (Firefox 49) with today's update.
Device Z3 tablet compact SGP611, Android 5.1.1
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 26

3 years ago
I was able to reproduce this issue on latest Aurora, on Samsung Galaxy S6 Edge(Android 5.1.1)
(Assignee)

Comment 27

3 years ago
(In reply to Flore Allemandou [:flore] from comment #25)
> It happened to me on nightly (Firefox 49) with today's update.
> Device Z3 tablet compact SGP611, Android 5.1.1

That's expected. See comment 13 and comment 18.
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED
(In reply to Sebastian Kaspari (:sebastian) from comment #27)
> (In reply to Flore Allemandou [:flore] from comment #25)
> > It happened to me on nightly (Firefox 49) with today's update.
> > Device Z3 tablet compact SGP611, Android 5.1.1
> 
> That's expected. See comment 13 and comment 18.

Oooops, sorry :( and thanks for your answer

Comment 29

3 years ago
After updating today to latest Aurora and Nightly, the icons remained on the homescreen. Will keep an eye on this, but this issue seems to be fixed. We'll verify this again tomorrow to make sure it's ok.
(Assignee)

Comment 30

3 years ago
With the next beta release we should make sure that Beta46->Beta47 (the new one) does not remove the icon. If this is the case then I'm confident that release46->release47 will work too. :)
(Assignee)

Updated

3 years ago
Duplicate of this bug: 1272656

Comment 32

3 years ago
Verified as fixed on Firefox 47 Beta 6, by upgrading from an older version(Firefox 46 Beta 10).
The icon remained on the homescreen.
Also marking this verified as fixed on latest Aurora and latest Nightly.
Reminder to self to check this is fixed when upgrading to Firefox 47 RC
Status: RESOLVED → VERIFIED
status-firefox47: fixed → verified
status-firefox48: fixed → verified
status-firefox49: fixed → verified
Flags: needinfo?(ioana.chiorean) → needinfo?(mihai.g.pop)

Comment 33

3 years ago
Verified as fixed after updating Firefox 46.0.1 to Firefox 47.0 RC
Flags: needinfo?(mihai.g.pop)
(Assignee)

Comment 34

3 years ago
(In reply to Mihai Pop from comment #33)
> Verified as fixed after updating Firefox 46.0.1 to Firefox 47.0 RC

Ah perfect! Thanks. :)
You need to log in before you can comment on or make changes to this bug.