Closed Bug 1256716 Opened 8 years ago Closed 2 years ago

[SM] Implement 'Edit Draft' command and hide it when not in a draft folder (port Thunderbird bug 1106412)

Categories

(SeaMonkey :: MailNews: Composition, defect)

Product:
SeaMonkey
Component:
MailNews: Composition
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.43 unaffected, seamonkey2.44 affected, seamonkey2.53+ fixed)

Status:
RESOLVED FIXED
Milestone:
Future
Tracking Flags:
Tracking Status
seamonkey2.43 --- unaffected
seamonkey2.44 --- affected
seamonkey2.53 + fixed

People

(Reporter: philip.chee, Assigned: iannbugzilla)

References

Details

(Whiteboard: SM2.53.12)

User Story

Port Thunderbird bugs:
> Bug 956481 - Remove ellipsis from some Message menuitems.
> Bug 957974 - Change "Message > Edit Message As New" to "Edit As New Message".
> Bug 1106412 - Menu items for "Edit draft" functionality missing after bug 321355 fixes "Edit as New Message" to do just that
> Bug 1297674 - Menu item 'Copy' is inactive when viewing .eml attachment
> Bug 731688 - Introduce compose type EditAsNew.
> Bug 731688 - Support conversion from HTML to plain text and vice versa in 'Edit as New Message', 'Edit Draft' and 'New Message from Template'.

Attachments

(1 file, 1 obsolete file)

1256716-editDraft-v1_1-25312.patch
20.08 KB, patch
frg
: review+
frg
: approval-comm-release+
frg
: approval-comm-esr60+
Details | Diff | Splinter Review 
      No description provided.
Flags: needinfo?(philip.chee)
IanN: This looks like something we should do. What do you think?
User Story: (updated)
Flags: needinfo?(rsx11m.pub)
Flags: needinfo?(philip.chee)
Flags: needinfo?(iann_bugzilla)
Summary: Implement Edit Draft Message Command and hide it when not in a draft folder (fallout from Bug 321355). → Implement Edit Draft Message as New Command and hide it when not in a draft folder ((Port Thunderbird Bug 1106412).
Yes, we should.
Flags: needinfo?(iann_bugzilla)
Summary: Implement Edit Draft Message as New Command and hide it when not in a draft folder ((Port Thunderbird Bug 1106412). → [SM] Implement 'Edit Draft' command and hide it when not in a draft folder (port Thunderbird bug 1106412)
User Story: (updated)
Assignee: nobody → iannbugzilla
Status: NEW → ASSIGNED
Attached patch 1256716-editDraft-25312.patch (obsolete) — — Splinter Review

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: no Edit Draft option
Testing completed (on m-c, etc.): 2.53.12
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: 5 changes, 3 new

Used functions as would be used when port Bug 1389062 rather than change them twice.

Flags: needinfo?(rsx11m.pub)
Attachment #9266692 - Flags: review?(frgrahl)
Attachment #9266692 - Flags: approval-comm-release?
Attachment #9266692 - Flags: approval-comm-esr60?
User Story: (updated)

Added ports for the relevant parts from Bug 731688

Attachment #9266692 - Attachment is obsolete: true
Attachment #9266692 - Flags: review?(frgrahl)
Attachment #9266692 - Flags: approval-comm-release?
Attachment #9266692 - Flags: approval-comm-esr60?
Attachment #9267571 - Flags: review?(frgrahl)
Attachment #9267571 - Flags: approval-comm-release?
Attachment #9267571 - Flags: approval-comm-esr60?

Comment on attachment 9267571 [details] [diff] [review]
1256716-editDraft-v1_1-25312.patch

LGTM

  •    dump("Unexpected nsIMsgCompType in NotifyComposeBodyReady (" +

In a future bug we should get rid of the dump statements in the file. Console warning or error would be better at least here I think.

Attachment #9267571 - Flags: review?(frgrahl)
Attachment #9267571 - Flags: review+
Attachment #9267571 - Flags: approval-comm-release?
Attachment #9267571 - Flags: approval-comm-release+
Attachment #9267571 - Flags: approval-comm-esr60?
Attachment #9267571 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/08531a764e39
[SM] Implement 'Edit Draft' command and hide it when not in a draft folder (port Thunderbird bug 1106412). r=frg

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Whiteboard: SM2.53.12
status-firefox48: affected → ---
tracking-seamonkey2.53: --- → ?

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/7dc5db0a2612e2edeef41e226ea35a0b77bf228d
[SM] Implement 'Edit Draft' command and hide it when not in a draft folder (port Thunderbird bug 1106412). r=frg a=frg

status-seamonkey2.41: unaffected → ---
status-seamonkey2.42: unaffected → ---
status-seamonkey2.46: affected → ---
status-seamonkey2.53: --- → fixed
tracking-seamonkey2.53: ? → +
Target Milestone: --- → Future
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: