1256778 - [ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_bug664688_sandbox_update_after_navigation.js

Status: RESOLVED FIXED

(DevTools :: Console, defect, P3)

Description

[Lin Clark [:linclark]]

If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up

Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards

Then you can see the issues that need to be fixed by running

> eslint --no-ignore devtools/client/webconsole/test/browser_bug664688_sandbox_update_after_navigation.js

Comment 1

[Wellington Cordeiro [:wldcordeiro]]

I'll take this one. Feel free to assign to me.

Comment 2

[Michael Kohler [:mkohler]]

(In reply to Wellington Cordeiro from comment #1)
> I'll take this one. Feel free to assign to me.

I have actually a patch almost ready. Would you mind taking another one from https://bugzilla.mozilla.org/buglist.cgi?chfield=%5BBug%20creation%5D&chfieldfrom=2016-03-14&short_desc_type=allwordssubstr&known_name=eslint&short_desc=%5BESLint%5D&resolution=---&query_based_on=eslint&chfieldto=Now&query_format=advanced&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&component=Developer%20Tools%3A%20Console&product=Firefox&list_id=12920760 ?

Comment 3

[Michael Kohler [:mkohler]]

Attachment: 0001-Bug-1256778-ESLint.patch

Comment 4

[Michael Kohler [:mkohler]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=879c20dbdda7

Comment 5

[Jason Laster [:jlast]]

per bgrins comment on this bug 1256848, I believe that the yield for loadUri is unnecessary.

Comment 6

[Brian Grinstead [:bgrins]]

Comment on attachment 8749971 [details] [diff] [review]
0001-Bug-1256778-ESLint.patch

Review of attachment 8749971 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/webconsole/test/browser_bug664688_sandbox_update_after_navigation.js
@@ +42,4 @@
>    yield waitForMessages(msgForLocation1);
>  
>    // load second url
> +  yield BrowserTestUtils.loadURI(gBrowser.selectedBrowser, TEST_URI2);

Yeah, no need to yield here

Comment 7

[Michael Kohler [:mkohler]]

This has been fixed in the mean time.