1256822 - [ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_webconsole_bug_580001_closing_after_completion.js

Status: RESOLVED FIXED

(DevTools :: Console, defect, P3)

Description

[Lin Clark [:linclark]]

If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up

Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards

Then you can see the issues that need to be fixed by running

> eslint --no-ignore devtools/client/webconsole/test/browser_webconsole_bug_580001_closing_after_completion.js

Comment 1

[Fabien]

Attachment: 0001-Bug-1256822-ESLint-Fix-ESLint-issues-in-devtools-cli.patch

Notice linting `error  'promise' is not defined` is not removed in this patch as it should be fixed somehow globally -> this error is present in many places.

Comment 2

[Lin Clark [:linclark]]

Good call! We can fix that by putting an .eslintrc in the directory. Look here for an example:

https://dxr.mozilla.org/mozilla-central/source/devtools/client/animationinspector/test/.eslintrc

I created a bug for this, Bug 1269372

Comment 3

[Lin Clark [:linclark]]

Comment on attachment 8747442 [details] [diff] [review]
0001-Bug-1256822-ESLint-Fix-ESLint-issues-in-devtools-cli.patch

Review of attachment 8747442 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me!

Before we commit this, could you add the reviewer to the commit message? You can find the instructions here: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Creating_a_patch_to_check_in. For this one, you can just add r=linclark

Comment 4

[Martin Giger [:freaktechnik]]

The "'promise' is not defined" error would also be fixed with the modification of head.js in bug 1256795 (https://bugzilla.mozilla.org/attachment.cgi?id=8747443&action=diff#a/devtools/client/webconsole/test/head.js_sec2).

Comment 5

[Tim Nguyen :ntim]

Bug 1271084 fixed this bug.