1256854 - [ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_webconsole_bug_618078_network_exceptions.js

Status: RESOLVED FIXED

(DevTools :: Console, defect, P3)

Description

[Lin Clark [:linclark]]

If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up

Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards

Then you can see the issues that need to be fixed by running

> eslint --no-ignore devtools/client/webconsole/test/browser_webconsole_bug_618078_network_exceptions.js

Comment 1

[Michael Kohler [:mkohler]]

Attachment: patch1.patch

Comment 2

[Michael Kohler [:mkohler]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c8d38c4653e3

Comment 3

[Lin Clark [:linclark]]

Comment on attachment 8747459 [details] [diff] [review]
patch1.patch

Review of attachment 8747459 [details] [diff] [review]:
-----------------------------------------------------------------

Just mentioned in Bug 1256863, there's a little known but slightly simpler way to do this with BrowserTestUtils.

Comment 4

[Michael Kohler [:mkohler]]

Attachment: 0001-Bug-1256854-ESLint-Fix-ESLint-issues-in-devtools-cli.patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=07cdc4be7841

Comment 5

[Lin Clark [:linclark]]

Comment on attachment 8747890 [details] [diff] [review]
0001-Bug-1256854-ESLint-Fix-ESLint-issues-in-devtools-cli.patch

Review of attachment 8747890 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me :) This is r+ contingent on it passing on try.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/1e8d203b0d6b

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1e8d203b0d6b

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f8c2d37d2714