Closed Bug 1256854 Opened 5 years ago Closed 4 years ago

[ESLint] Fix ESLint issues in devtools/client/webconsole/test/browser_webconsole_bug_618078_network_exceptions.js

Categories

(DevTools :: Console, defect, P3)

defect

Tracking

(firefox48 fixed, firefox49 fixed)

RESOLVED FIXED
Firefox 49
Tracking Status
firefox48 --- fixed
firefox49 --- fixed

People

(Reporter: linclark, Assigned: mkohler, Mentored)

References

Details

(Whiteboard: [btpp-backlog])

Attachments

(1 file, 1 obsolete file)

If you haven’t contributed to Firefox before, follow the steps here to set up your environment: https://developer.mozilla.org/en-US/docs/Tools/Contributing#Getting_set_up

Then, automatically configure ESLint to work with the Firefox specific rules by following the instructions here: https://wiki.mozilla.org/DevTools/CodingStandards

Then you can see the issues that need to be fixed by running

> eslint --no-ignore devtools/client/webconsole/test/browser_webconsole_bug_618078_network_exceptions.js
Blocks: 1256948
Priority: -- → P3
Whiteboard: [btpp-backlog]
Attached patch patch1.patch (obsolete) — Splinter Review
Assignee: nobody → me
Status: NEW → ASSIGNED
Attachment #8747459 - Flags: review?(lclark)
Comment on attachment 8747459 [details] [diff] [review]
patch1.patch

Review of attachment 8747459 [details] [diff] [review]:
-----------------------------------------------------------------

Just mentioned in Bug 1256863, there's a little known but slightly simpler way to do this with BrowserTestUtils.
Attachment #8747459 - Flags: review?(lclark)
Comment on attachment 8747890 [details] [diff] [review]
0001-Bug-1256854-ESLint-Fix-ESLint-issues-in-devtools-cli.patch

Review of attachment 8747890 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me :) This is r+ contingent on it passing on try.
Attachment #8747890 - Flags: review?(lclark) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1e8d203b0d6b
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.