Closed
Bug 1257087
Opened 8 years ago
Closed 8 years ago
Middle mouse click on history item would not open
Categories
(Firefox :: Bookmarks & History, defect, P2)
Tracking
()
VERIFIED
FIXED
Firefox 49
People
(Reporter: alice0775, Assigned: dao)
References
Details
(Keywords: regression)
Attachments
(2 files)
3.83 KB,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
2.00 KB,
patch
|
Sylvestre
:
approval-mozilla-aurora+
ritu
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
[Tracking Requested - why for this release]: regression Reproducible: always Steps to reproduce: 1. Open hamburger menu 2. Click History icon 3. Middle mouse click on history item Actual results: Nothing happens Expected results: The history item should be opened in new tab
Reporter | ||
Comment 1•8 years ago
|
||
Regression window: https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=164d5bc71555fe593f7726ff208dccb730073f34&tochange=26771bc857f867ab6fa34c7a6ec87f92e79ce4e8 Regressed by : Bug 1249473
Blocks: 1249473
Reporter | ||
Updated•8 years ago
|
Flags: needinfo?(mak77)
Flags: needinfo?(dao)
Comment 2•8 years ago
|
||
well, we also need middle click working for recent bookmarks, so let's use this for both.
Flags: needinfo?(mak77)
Recent regression in 47, tracked 47+
Updated•8 years ago
|
Version: 47 Branch → 48 Branch
Updated•8 years ago
|
Priority: -- → P2
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → dao+bmo
Flags: needinfo?(dao+bmo)
Updated•8 years ago
|
Attachment #8756263 -
Flags: review?(mak77) → review+
Assignee | ||
Comment 7•8 years ago
|
||
I believe bug 1248267 fixed this for recent bookmarks.
Attachment #8756263 -
Flags: review?(mak77)
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5444f0c1e330
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Assignee | ||
Comment 9•8 years ago
|
||
Approval Request Comment [Feature/regressing bug #]: bug 1249473 [User impact if declined]: see comment 0 (only history widget items are affected, the recent bookmarks list isn't on beta / aurora) [Describe test coverage new/current, TreeHerder]: no coverage [Risks and why]: trivial fix, low risk [String/UUID change made/needed]: none
Attachment #8757254 -
Flags: approval-mozilla-beta?
Attachment #8757254 -
Flags: approval-mozilla-aurora?
Assignee | ||
Updated•8 years ago
|
Comment 10•8 years ago
|
||
Comment on attachment 8757254 [details] [diff] [review] patch for uplift Recent regression, taking it
Attachment #8757254 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 11•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/de472f31c8a3
Comment 12•8 years ago
|
||
This is marked as a regression in 47; can we uplift to beta?
Flags: needinfo?(rkothari)
(In reply to Andrew Overholt [:overholt] from comment #12) > This is marked as a regression in 47; can we uplift to beta? Yes, this seems like a low-risk fix and recent regression. I will take it in RC1.
Flags: needinfo?(rkothari)
Comment on attachment 8757254 [details] [diff] [review] patch for uplift This is a recent and very visible end-user regression, let's uplift to Beta47
Attachment #8757254 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 15•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/860a355f185a
Updated•8 years ago
|
Flags: qe-verify+
Comment 16•8 years ago
|
||
Reproduced on Nightly 2016-03-23. Verified fixed FX 47 RC build 3, 48.0a2 (2016-06-05), 49.0a1 (2016-06-05) Win 7
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•