1257662 - Disallow clearing a flag if the flag is set to allow granting by specifc group and changer is not in group

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Bug Creation/Editing, defect)

Description

[David Lawrence [:dkl]]

Update the code so that if a flag has been granted/denied and the flag has a specific group that is required to do so, only users in the grant group can clear the flag or put back to requested (?). Flags without a specific grant group would behave normally.

This came about due to users not being able to set sec-bounty? flag anymore since some were cleared that should not have.

dkl

Comment 1

[David Lawrence [:dkl]]

Attachment: 1257662_1.patch

Comment 2

[:glob ✱]

Comment on attachment 8731896 [details] [diff] [review]
1257662_1.patch

Review of attachment 8731896 [details] [diff] [review]:
-----------------------------------------------------------------

extensions/BugModal/template/en/default/bug_modal/flags.html.tmpl needs updating too

Comment 3

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8731896 [details] [diff] [review]
1257662_1.patch

Review of attachment 8731896 [details] [diff] [review]:
-----------------------------------------------------------------

No problems yet in the old UI, but glob's right.

r-

Comment 4

[David Lawrence [:dkl]]

Attachment: 1257662_2.patch

Comment 5

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8733005 [details] [diff] [review]
1257662_2.patch

Review of attachment 8733005 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan works as described. Will this break any tests? (wishing it was easier to run all the tests against a checkout)

Comment 6

[David Lawrence [:dkl]]

(In reply to Dylan William Hardison [:dylan] from comment #5)
> Comment on attachment 8733005 [details] [diff] [review]
> 1257662_2.patch
> 
> Review of attachment 8733005 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=dylan works as described. Will this break any tests? (wishing it was
> easier to run all the tests against a checkout)

We'll find out.

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   c83c4f7..fc2d539  master -> master

dkl