Closed
Bug 1257804
Opened 8 years ago
Closed 8 years ago
Copying "normal" URL from location bar when in reader mode broke (now includes "about:reader?url=" and escapes the real URL)
Categories
(Firefox :: Address Bar, defect)
Firefox
Address Bar
Tracking
()
VERIFIED
FIXED
Firefox 48
Tracking | Status | |
---|---|---|
firefox45 | --- | unaffected |
firefox46 | --- | unaffected |
firefox47 | + | verified |
firefox48 | --- | verified |
People
(Reporter: Gijs, Assigned: Gijs)
References
Details
(Keywords: regression)
Attachments
(1 file)
58 bytes,
text/x-review-board-request
|
jaws
:
review+
ritu
:
approval-mozilla-aurora+
|
Details |
Noticed this today when reviewing narrator changes. This is a regression from bug 824887. When we implemented reader mode in desktop, we made sure copying the URL just copied the "regular" URL instead of the bit including "about:reader?url=" and the escaped copy of the URL. It looks like this somehow broke in bug 824887. [Tracking Requested - why for this release]: regression for 47
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/41379/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/41379/
Attachment #8732803 -
Flags: review?(dolske)
Assignee | ||
Comment 2•8 years ago
|
||
https://reviewboard.mozilla.org/r/41379/#review37853 ::: browser/base/content/urlbarBindings.xml:615 (Diff revision 1) > + // Avoid copying 'about:reader?url=', and always provide the original URI: > + let readerOriginalURL = ReaderMode.getOriginalUrl(uri.spec); > + if (readerOriginalURL) { > + uri = uriFixup.createFixupURI(readerOriginalURL, Ci.nsIURIFixup.FIXUP_FLAG_NONE); > + } Could keep this strictly within the pageproxystate == "valid" case in the if statement above this, but this seemed easier to read, more generic, and more futureproof.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
New regression in Fx47, tracked.
Comment 5•8 years ago
|
||
Comment on attachment 8732803 [details] MozReview Request: Bug 1257804 - avoid copy-pasting about:reader and copy-paste the URL instead, r?dolske https://reviewboard.mozilla.org/r/41379/#review39163
Attachment #8732803 -
Flags: review+
Updated•8 years ago
|
Attachment #8732803 -
Flags: review?(dolske)
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/48d54c93dcf3
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Assignee | ||
Comment 8•8 years ago
|
||
Comment on attachment 8732803 [details] MozReview Request: Bug 1257804 - avoid copy-pasting about:reader and copy-paste the URL instead, r?dolske Approval Request Comment [Feature/regressing bug #]: bug 824887 [User impact if declined]: about:reader shows up in URLs when copied from the URL bar while in reader mode [Describe test coverage new/current, TreeHerder]: patch has a test to avoid re-regressing this [Risks and why]: pretty low, the escaping functionality of the URL bar is fairly well-tested generally [String/UUID change made/needed]: nope.
Attachment #8732803 -
Flags: approval-mozilla-aurora?
Comment on attachment 8732803 [details] MozReview Request: Bug 1257804 - avoid copy-pasting about:reader and copy-paste the URL instead, r?dolske Recent regression, Aurora47+
Attachment #8732803 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Flags: qe-verify+
Comment 10•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/3e3bdbc7ac12
Comment 11•8 years ago
|
||
Reproduced this issue on 2016-03-18 Nightly (build ID 20160318030236) on Windows 10 x64. Confirming the fix across platforms using: * Firefox 47.0b1, build ID 20160425095909 * Latest 48.0a2 Aurora, build ID 20160425101338.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•