Closed Bug 1257919 Opened 4 years ago Closed 4 years ago

Stop using ThreadsafeAutoJSContext in DOM exception code

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(10 files)

3.65 KB, patch
khuey
: review+
Details | Diff | Splinter Review
6.48 KB, patch
khuey
: review+
Details | Diff | Splinter Review
8.43 KB, patch
khuey
: review+
Details | Diff | Splinter Review
14.88 KB, patch
khuey
: review+
Details | Diff | Splinter Review
14.37 KB, patch
khuey
: review+
Details | Diff | Splinter Review
16.64 KB, patch
khuey
: review+
Details | Diff | Splinter Review
4.70 KB, patch
khuey
: review+
Details | Diff | Splinter Review
15.38 KB, patch
khuey
: review+
Details | Diff | Splinter Review
4.80 KB, patch
khuey
: review+
Details | Diff | Splinter Review
9.12 KB, patch
khuey
: review+
Details | Diff | Splinter Review
This is going to be more exciting than one might think, because it involves using [explicit_jscontext] and hence not JS-implementing nsIException and the like.
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Comment on attachment 8733056 [details] [diff] [review]
part 5.  Get rid of the now-unused StackFrame class

Review of attachment 8733056 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/Exceptions.cpp
@@ +262,5 @@
>  {
>    MOZ_ASSERT(mStack);
>  
>    mozilla::HoldJSObjects(this);
>    mLineno = 0;

You're initializing mLineno twice.
> You're initializing mLineno twice.

Good catch, fixed.
The problem was the fix for bug 1256376.
Flags: needinfo?(bzbarsky)
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.