Closed
Bug 1257972
Opened 8 years ago
Closed 8 years ago
Put users currently running an experiment into "disqualified" cohort
Categories
(Firefox :: General, defect)
Tracking
()
RESOLVED
FIXED
Firefox 48
People
(Reporter: Felipe, Assigned: Felipe)
References
Details
Attachments
(1 file)
58 bytes,
text/x-review-board-request
|
mossop
:
review+
lizzard
:
approval-mozilla-aurora+
lizzard
:
approval-mozilla-beta+
|
Details |
I'm not sure if this will be a permanent thing, or just for the current testing that we're planning to do for beta46, but it was asked for this during today's meeting. The reason is because there's another experiment planned for now (bug 1248813) which explicitly targets getting stability and performance data, so it would be bad to mix those numbers with e10s usage.
Assignee | ||
Updated•8 years ago
|
Summary: Make the system add-on skip users of experiments → Put users currently running an experiment into "disqualified" cohort
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/41145/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/41145/
Attachment #8732370 -
Flags: review?(dtownsend)
Assignee | ||
Comment 2•8 years ago
|
||
Comment on attachment 8732370 [details] MozReview Request: Bug 1257972 - Put users currently running an experiment into the disqualified cohort of the e10s rollout system add-on. r=Mossop Approval Request Comment [Feature/regressing bug #]: needed to not conflate e10s users data with other experiments data [User impact if declined]: can contaminate the data of another planned experiment, as described in comment 0 here. [Describe test coverage new/current, TreeHerder]: in review [Risks and why]: minor, wouldn't cause any problems outside of the system add-on [String/UUID change made/needed]: none
Attachment #8732370 -
Flags: approval-mozilla-beta?
Attachment #8732370 -
Flags: approval-mozilla-aurora?
Comment 3•8 years ago
|
||
Comment on attachment 8732370 [details] MozReview Request: Bug 1257972 - Put users currently running an experiment into the disqualified cohort of the e10s rollout system add-on. r=Mossop https://reviewboard.mozilla.org/r/41145/#review37895 ::: browser/extensions/e10srollout/bootstrap.js:118 (Diff revision 1) > Preferences.get(PREF_TOGGLE_E10S) == false); > } > > +function isThereAnActiveExperiment() { > + let tmp = {}; > + Cu.import("resource:///modules/experiments/Experiments.jsm", tmp); You can also do: let { Experiments } = Cu.import("...", {});
Attachment #8732370 -
Flags: review?(dtownsend) → review+
Comment 5•8 years ago
|
||
Looks like this should uplift to 46/47.
Assignee | ||
Comment 7•8 years ago
|
||
http://hg.mozilla.org/releases/mozilla-aurora/rev/5edaa5a69616 http://hg.mozilla.org/releases/mozilla-beta/rev/1158965ce52d
status-firefox46:
--- → fixed
status-firefox47:
--- → fixed
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/08e7097a302f https://hg.mozilla.org/mozilla-central/rev/551375db18bf
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Comment 9•8 years ago
|
||
Comment on attachment 8732370 [details] MozReview Request: Bug 1257972 - Put users currently running an experiment into the disqualified cohort of the e10s rollout system add-on. r=Mossop Tweaking the approval flags after this already landed, we agreed on it over irc.
Attachment #8732370 -
Flags: approval-mozilla-beta?
Attachment #8732370 -
Flags: approval-mozilla-beta+
Attachment #8732370 -
Flags: approval-mozilla-aurora?
Attachment #8732370 -
Flags: approval-mozilla-aurora+
You need to log in
before you can comment on or make changes to this bug.
Description
•