1258212 - [e10s] navigator.registerContentHandler for RSS is broken

Status: VERIFIED FIXED

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Description

[ojab]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:47.0) Gecko/20100101 Firefox/47.0
Build ID: 20160320004007

Steps to reproduce:

1. Go to https://newsblur.com
2. Click Try out NewsBlur
3. Click on the gear in the bottom of left sidebar
4. Select Goodies & Mobile Apps
5. Click on the ADD TO FIREFOX button right to "Firefox: Register NewsBlur as an RSS reader" line


Actual results:

Nothing


Expected results:

Newblur RSS handler should be added

Comment 1

[ojab]

Basically it does
e = "https://www.newsblur.com/"
navigator.registerContentHandler('application/vnd.mozilla.maybe.feed', e + '?url=%s', 'NewsBlur');
navigator.registerContentHandler('application/atom+xml', e + '?url=%s', 'NewsBlur');
navigator.registerContentHandler('application/rss+xml', e + '?url=%s', 'NewsBlur')

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Patch

It looks like we just forgot to hook the message up to the message manager. I tried writing a mochitest for this, but it ended up being harder than I thought it'd be, so I'm just going to check this in.

Comment 3

[George Wright (:gw280) (needinfo me!)]

Comment on attachment 8746236 [details] [diff] [review]
Patch

Review of attachment 8746236 [details] [diff] [review]:
-----------------------------------------------------------------

Presumably this needs a test?

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5f3d4dd4380f

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5f3d4dd4380f

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Do we need to uplift?  Seems like at least 47 and later could be affected...  Wherever e10s would be enabled I guess?

Comment 7

[George Wright (:gw280) (needinfo me!)]

It could go either way. I don't think it's a risky change, but I also don't think many people use this feature. We can probably just go ahead and uplift.

Comment 8

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8746236 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: n/a (this never worked in e10s before)
[User impact if declined]: web sites that use navigator.registerContentHandler wouldn't be able to prompt the user to add them as an RSS reader.
[Describe test coverage new/current, TreeHerder]: Under covered :-(
[Risks and why]: Low risk.
[String/UUID change made/needed]: n/a

Comment 9

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8746236 [details] [diff] [review]
Patch

e10s related, Aurora48+, Beta47+

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/31c52d84503f

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8cc479e68161

Comment 12

[Nawaf Chowdhury Akash]

I have reproduced this bug with Nightly 48.0a1 (2016-03-20) on Windows 10 , 32 bit.

This Bug's fix is verified on Latest beta 49.0b1 and Latest release 48 .

Build ID : 20160802125918
User Agent:Mozilla/5.0 (Windows NT 10.0; rv:49.0) Gecko/20100101 Firefox/49.0.


Build ID : 20160726073904
User Agent:Mozilla/5.0 (Windows NT 10.0; rv:48.0) Gecko/20100101 Firefox/48.0.

[bugday-20160810]