1258298 - Switch more Scoped.h templates in PSM to UniquePtr equivalents

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[:Cykesiopka]

Scoped.h is deprecated, so PSM should continue migrating to UniquePtr.
In addition, adding more UniquePtr templates will slightly reduce conversion friction for consumers of ScopedNSSTypes.h.

Comment 1

[:Cykesiopka]

(Updating summary because I found more Scoped.h templates that can be converted as part of this bug.)

Comment 2

[:Cykesiopka]

Attachment: MozReview Request: Bug 1258298 - Switch more Scoped.h templates in PSM to UniquePtr equivalents.

Review commit: https://reviewboard.mozilla.org/r/42383/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/42383/

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Comment on attachment 8734654 [details]
MozReview Request: Bug 1258298 - Switch more Scoped.h templates in PSM to UniquePtr equivalents.

https://reviewboard.mozilla.org/r/42383/#review38991

LGTM - see comment though.

::: security/manager/ssl/ScopedNSSTypes.h:371
(Diff revision 1)
> +                                      PK11_FreeSymKey)
>  
>  MOZ_TYPE_SPECIFIC_UNIQUE_PTR_TEMPLATE(UniquePLArenaPool,
>                                        PLArenaPool,
>                                        internal::PORT_FreeArena_false)
> +MOZ_TYPE_SPECIFIC_UNIQUE_PTR_TEMPLATE(UniquePORTString,

There are some places in PSM where we're using the long form of an equivalent of this (e.g. https://dxr.mozilla.org/mozilla-central/rev/d5f3da0cfe7ccf846c354014c9b059fad6ba0de5/security/manager/ssl/SSLServerCertVerification.cpp#894 ). It would be nice to update them to use UniquePORTString.

Comment 4

[:Cykesiopka]

https://reviewboard.mozilla.org/r/42383/#review38991

Thanks for the review!

> There are some places in PSM where we're using the long form of an equivalent of this (e.g. https://dxr.mozilla.org/mozilla-central/rev/d5f3da0cfe7ccf846c354014c9b059fad6ba0de5/security/manager/ssl/SSLServerCertVerification.cpp#894 ). It would be nice to update them to use UniquePORTString.

Noted. I have a WIP for using UniquePORTString more in PSM anyways, so I'll make those changes in Bug 1259909 as well.

Comment 5

[:Cykesiopka]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5b277587678b

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/163b4a287e0a

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/163b4a287e0a