125877 - uninstall doesn't remove all entries from Windows registry

Status: RESOLVED WORKSFORME

(SeaMonkey :: Installer, defect)

Description

[Karl Johan Kleist]

Build ID: Mozilla 0.9.8. Windows 2000.

After uninstalling Mozilla 0.9.8 several entries referencing the "mozilla.org"
folder remained in the Windows registry:

One entry for this key:

HKEY_LOCAL_MACHINE\SOFTWARE\FullCircle\TalkBack\NetscapeMozillaBranchWin322002020409

Several entries for this key:

HKEY_LOCAL_MACHINE\SOFTWARE\Mozilla\Desktop

In case it's important: In parallell to 0.9.8 I have installed nightly
talkback builds. I never run 0.9.8 concurrently with a nightly, though.

Comment 1

[Henrik Gemal]

also related is bug 113593 "uninstall doesn't remove all files"

Basiclly "uninstall" isn't really unintall. It's "remove almost everything"...:)

Uninstall should be uninstall (remove everything). Plugins should be left behind
though...

Comment 2

[Henrik Gemal]

The reg.db is flooded with entries about mozilla after uninstall.

These entries are left after installing Mozilla on a clean new Windows 2000 and 
then uninstalling it:

HKEY_CLASSES_ROOT\CLSID\{29F458BE-8866-11D5-A3DD-00B0D0F3BAA7}
HKEY_CLASSES_ROOT\mozMapi
HKEY_CLASSES_ROOT\mozMapi.1
HKEY_CLASSES_ROOT\MozillaGIF
HKEY_CLASSES_ROOT\MozillaHTML
HKEY_CLASSES_ROOT\MozillaJPEG
HKEY_CLASSES_ROOT\MozillaMNG
HKEY_CLASSES_ROOT\MozillaPNG
HKEY_CLASSES_ROOT\MozillaXHTML
HKEY_CLASSES_ROOT\MozillaXML
HKEY_CLASSES_ROOT\MozillaXUL
HKEY_CURRENT_USER\Software\Mozilla
HKEY_CURRENT_USER\Software\mozilla.org
HKEY_LOCAL_MACHINE\SOFTWARE\Classes\CLSID\{29F458BE-8866-11D5-A3DD-00B0D0F3BAA7}
HKEY_LOCAL_MACHINE\SOFTWARE\Classes\mozMapi
HKEY_LOCAL_MACHINE\SOFTWARE\Classes\mozMapi.1
HKEY_LOCAL_MACHINE\SOFTWARE\Classes\\MozillaGIF
HKEY_LOCAL_MACHINE\SOFTWARE\Classes\\MozillaHTML
HKEY_LOCAL_MACHINE\SOFTWARE\Classes\\MozillaJPEG
HKEY_LOCAL_MACHINE\SOFTWARE\Classes\\MozillaMNG
HKEY_LOCAL_MACHINE\SOFTWARE\Classes\\MozillaPNG
HKEY_LOCAL_MACHINE\SOFTWARE\Classes\\MozillaXHTML
HKEY_LOCAL_MACHINE\SOFTWARE\Classes\\MozillaXML
HKEY_LOCAL_MACHINE\SOFTWARE\Classes\\MozillaXUL

Uninstall should be UNINSTALL!

Comment 3

[Daniel Veditz [:dveditz]]

Curt, Sean may have ideas on how to approach this. These settings are made by
the browser itself so it's harder for the uninstall to know about them. However,
there may be a way to use the information in HKLM\Software\Mozilla\Desktop, or
we can code fakes into the script using logComment the way we handle generated
files.

Comment 4

[Andrew Hagen]

Can't we just try to delete all the registry entries that Mozilla might create?

Comment 5

[Henrik Gemal]

*** Bug 170666 has been marked as a duplicate of this bug. ***

Comment 6

[Henrik Gemal]

are anybody working on this?
what's the ETA? we currently have mozilla1.0.1 and nsbeta1-

Comment 7

[David G King]

Changing Keywords and Target Milestone to match Bug # 113593 which is very
similar but deals with files rather than Registry Entries.

As for an ETA, I don't think anyone is working on it as it is marked NEW rather
than ASSIGNED.

Comment 8

[David G King]

From looking at rdi.c there is a place there that deletes everything in
HKEY_LOCAL_MACHINE\SOFTWARE\Mozilla\Desktop and (in theory)
HKEY_LOCAL_MACHINE\SOFTWARE\Mozilla

It seems to me that UndoDesktopIntegration (that resides in rdi.c) just needs to
be embellished to include the registry entries from Comment #2.

Comment 9

[David G King]

Attachment: Partial patch to remove some more Win32 registry keys on uninstall.

This is the first C code that I've written in about 10 years, so be kind. Also,
it doesn't remove all the registry keys, but is rather intended as a base for
further expansion depending on how much C I've forgotten.

Comment 10

[Sean Su]

Comment on attachment 107356 [details] [diff] [review]
Partial patch to remove some more Win32 registry keys on uninstall.

the deletion needs to take place inside the for() loop so it can be disabled
along  with the other code.

Also I have a feeling that if there happen to be multiple installations of
Mozilla (in different dirs), and the user only uninstalls one of them, deleting
these keys might cause problems with the OS attempting to locate the default
browser, which might still be Mozilla.

Comment 11

[Curt Patrick (gone)]

I recommend pinging Sean for reviews on this bug since it appears that I will be
moving on to other activities before this patch is finalized.  Besides, he seems
to know what he is talking about. :-)

Comment 12

[Sean Su]

just did a quick test:
  1) mozilla is installed
  2) N7 is installed (does not have to be N7.  could be just another copy of
mozilla installed elsewhere).
  3) make sure N7 is default browser for HTML files
  4) uninstall mozilla
  5) delete or rename the HKEY_CLASSES_ROOT\MozillaHTML out of the way by hand
via regedit.exe
  6) make sure N7 is not running
  7) double click on an .html file on the system.

A dialog asking which app to open the .html file with is shown:
  dialog: "Open With"
  message: Click the program you want to use to open 'file.html'.
           If the program is not in the list, click Other.

           Choose the program you wan to use:
           [list of apps registered with the system]

I don't think it's a good idea to remove the keys listed in the patch.  They are
hamrless if left on the system, but I understand, that's not really the point.

The correct way is to make sure that the keys to be deleted are not registered
to another copy of mozilla/n7, but that would be a slightly more complicated
patch than the one attached.

Comment 13

[David G King]

I never even thought about another browser using the same keys. In a perfect
world, Netscape probably shouldn't use Mozilla keys, however I doubt there is
any way around that issue.

Also, the last paragraph from Sean in Comment #12 is probably the key solution,
and also way outside of my capabilities. Although I'm sure there is a Microsoft
function to determine if a key is being used by a different program.

Comment 14

[Sean Su]

It's not just N7, but also another copy of Mozilla installed elsewhere on the
same system.  Most (N7) users won't do that, but I have a feeling that most of
the Mozilla community (running Mozilla) will.

Comment 15

[David G King]

Attachment: Minor changes and some comments added, not ready for R or SR as yet.

This puts the for loop inside the if, which I should have done anyway. I've
also added comments to say that these keys can't be deleted if used by another
program (but no code for this yet). Any ideas are welcome.

Comment 16

[David G King]

Re: Comment #12

From doing some digging, the reason you got the message about what app to use is
because you just removed "C:\PROGRA~1\MOZILLA.ORG\MOZILLA\MOZILLA.EXE -url "%1""
which was being used to define what Windows should use to open an HTML file.
What's more, if you uninstalled Mozilla (and left that key as it was
originally), you would get the same message (or maybe something about
Mozilla.Exe can't be found).

Comment 17

[Henrik Gemal]

*** Bug 183214 has been marked as a duplicate of this bug. ***

Comment 18

[Sean Su]

should be really me.

Comment 19

[Henrik Gemal]

*** Bug 224054 has been marked as a duplicate of this bug. ***

Comment 20

[David G King]

From work I've been doing on Bug #219938, this bug isn't going to be easy. Also,
with the recent events regarding AOL/Netscape/Mozilla, along with the
Mozilla/Firebird/Thunderbird/Sunbird situation, I'm very close to saying that
this bug doesn't have a good work/benefit ratio.

However, leaving entries in the Registry that aren't useful to any "Mozilla"
program isn't good. Having said that, getting the Registry to be set correctly
on running/installing Mozilla is more important that getting the Registry clean
after an uninstall.

Comment 21

[Matthias Versen [:Matti]]

Seamonkey and Firefox are using a new NSIS based installer. resolving this old bug, please reopen if you still get this with the new installer