1258785 - "checking yasm version... Traceback" after "checking for yasm... not found"

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Nick Alexander :nalexander [he/him] (PTO Feb 24-March 3)]

margaret reports problems building Fennec on Mac OS X, with --enable-artifact-builds.  In this configuration, yasm should not be required, so we probably shouldn't even check for it.  However, if it's not found, we *definitely* shouldn't version check.

Log snippet:

 0:01.31 checking for yasm... not found
 0:01.31 checking yasm version... Traceback (most recent call last):
 0:01.31   File "/Users/leibovic/code/fx-team/configure.py", line 82, in <module>
 0:01.31     sys.exit(main(sys.argv))
 0:01.31   File "/Users/leibovic/code/fx-team/configure.py", line 22, in main
 0:01.31     sandbox.run(os.path.join(os.path.dirname(__file__), 'moz.configure'))
 0:01.31   File "/Users/leibovic/code/fx-team/python/mozbuild/mozbuild/configure/__init__.py", line 179, in run
 0:01.31     self.exec_file(path)
 0:01.31   File "/Users/leibovic/code/fx-team/python/mozbuild/mozbuild/configure/__init__.py", line 172, in exec_file
 0:01.31     exec(code, self)
 0:01.31   File "/Users/leibovic/code/fx-team/moz.configure", line 129, in <module>
 0:01.31     @advanced
 0:01.31   File "/Users/leibovic/code/fx-team/python/mozbuild/mozbuild/configure/__init__.py", line 353, in decorator
 0:01.31     self._results[func] = func(*resolved_args)
 0:01.31   File "/Users/leibovic/code/fx-team/build/moz.configure/checks.configure", line 32, in wrapped
 0:01.31     ret = func(*args, **kwargs)
 0:01.31   File "/Users/leibovic/code/fx-team/moz.configure", line 135, in yasm_version
 0:01.31     [yasm, '--version']
 0:01.31   File "/usr/local/Cellar/python/2.7.10_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 566, in check_output
 0:01.31     process = Popen(stdout=PIPE, *popenargs, **kwargs)
 0:01.31   File "/usr/local/Cellar/python/2.7.10_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 710, in __init__
 0:01.31     errread, errwrite)
 0:01.31   File "/usr/local/Cellar/python/2.7.10_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 1335, in _execute_child
 0:01.31     raise child_exception
 0:01.31 OSError: [Errno 2] No such file or directory
 0:01.32 *** Fix above errors and then restart with               "/Applications/Xcode.app/Contents/Developer/usr/bin/make -f client.mk build"
 0:01.32 make[2]: *** [configure] Error 1
 0:01.32 make[1]: *** [/Users/leibovic/code/fx-team/objdir-frontend/Makefile] Error 2
 0:01.32 make: *** [build] Error 2
 0:01.33 0 compiler warnings present.

Comment 1

[(not currently active) Ted Mielczarek]

Oh, apparently the code I wrote doesn't work:
https://hg.mozilla.org/integration/mozilla-inbound/annotate/d5efe76a40b3/moz.configure#l131

because of:
https://dxr.mozilla.org/mozilla-central/rev/4037eb98974db1b1e0b5012c8a7f3a36428eaa11/build/moz.configure/checks.configure#68

check_prog will return 'not found' for missing programs, which is obviously not a falsy value! I wonder if we could just use `None` instead?

Comment 2

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1258785 - Return a None value when check_prog doesn't find a program. r?ted

Review commit: https://reviewboard.mozilla.org/r/41849/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/41849/

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 8733643 [details]
MozReview Request: Bug 1258785 - Return a None value when check_prog doesn't find a program. r?ted

https://reviewboard.mozilla.org/r/41849/#review38349

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9056b43dc7b1

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9056b43dc7b1