Closed Bug 1258785 Opened 5 years ago Closed 5 years ago

"checking yasm version... Traceback" after "checking for yasm... not found"


(Firefox Build System :: General, defect)

Not set


(firefox48 fixed)

Tracking Status
firefox48 --- fixed


(Reporter: nalexander, Unassigned)




(1 file)

margaret reports problems building Fennec on Mac OS X, with --enable-artifact-builds.  In this configuration, yasm should not be required, so we probably shouldn't even check for it.  However, if it's not found, we *definitely* shouldn't version check.

Log snippet:

 0:01.31 checking for yasm... not found
 0:01.31 checking yasm version... Traceback (most recent call last):
 0:01.31   File "/Users/leibovic/code/fx-team/", line 82, in <module>
 0:01.31     sys.exit(main(sys.argv))
 0:01.31   File "/Users/leibovic/code/fx-team/", line 22, in main
 0:01.31, 'moz.configure'))
 0:01.31   File "/Users/leibovic/code/fx-team/python/mozbuild/mozbuild/configure/", line 179, in run
 0:01.31     self.exec_file(path)
 0:01.31   File "/Users/leibovic/code/fx-team/python/mozbuild/mozbuild/configure/", line 172, in exec_file
 0:01.31     exec(code, self)
 0:01.31   File "/Users/leibovic/code/fx-team/moz.configure", line 129, in <module>
 0:01.31     @advanced
 0:01.31   File "/Users/leibovic/code/fx-team/python/mozbuild/mozbuild/configure/", line 353, in decorator
 0:01.31     self._results[func] = func(*resolved_args)
 0:01.31   File "/Users/leibovic/code/fx-team/build/moz.configure/checks.configure", line 32, in wrapped
 0:01.31     ret = func(*args, **kwargs)
 0:01.31   File "/Users/leibovic/code/fx-team/moz.configure", line 135, in yasm_version
 0:01.31     [yasm, '--version']
 0:01.31   File "/usr/local/Cellar/python/2.7.10_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/", line 566, in check_output
 0:01.31     process = Popen(stdout=PIPE, *popenargs, **kwargs)
 0:01.31   File "/usr/local/Cellar/python/2.7.10_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/", line 710, in __init__
 0:01.31     errread, errwrite)
 0:01.31   File "/usr/local/Cellar/python/2.7.10_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/", line 1335, in _execute_child
 0:01.31     raise child_exception
 0:01.31 OSError: [Errno 2] No such file or directory
 0:01.32 *** Fix above errors and then restart with               "/Applications/ -f build"
 0:01.32 make[2]: *** [configure] Error 1
 0:01.32 make[1]: *** [/Users/leibovic/code/fx-team/objdir-frontend/Makefile] Error 2
 0:01.32 make: *** [build] Error 2
 0:01.33 0 compiler warnings present.
Oh, apparently the code I wrote doesn't work:

because of:

check_prog will return 'not found' for missing programs, which is obviously not a falsy value! I wonder if we could just use `None` instead?
Flags: needinfo?(mh+mozilla)
Flags: needinfo?(mh+mozilla)
Comment on attachment 8733643 [details]
MozReview Request: Bug 1258785 - Return a None value when check_prog doesn't find a program. r?ted
Attachment #8733643 - Flags: review?(ted) → review+
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Blocks: 1259275
Blocks: 1259346
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.