1259275 - "checking yasm version... Traceback" after "checking for yasm... not found"

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

Bug 1258785 dealt with not running the version check when yasm is not found, but the more fundamental problem is that we're checking yasm at all when doing builds without a compile environment.

Comment 1

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1259275 - Don't check for yasm when building with --disable-compile-environment. r?ted

Review commit: https://reviewboard.mozilla.org/r/42129/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/42129/

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 8734174 [details]
MozReview Request: Bug 1259275 - Don't check for yasm when building with --disable-compile-environment. r?ted

https://reviewboard.mozilla.org/r/42129/#review38663

::: moz.configure:62
(Diff revision 1)
> +@depends('--disable-compile-environment', '--help')
> +def toolchain_include(value, help):
> +    if value:
> +        return 'build/moz.configure/toolchain.configure'
> +
> +include(toolchain_include)

This is an odd construct, I'm having a hard time forming a mental model of how it works. I'm OK with landing this as-is, but maybe we could file a followup on making this clearer?

Comment 3

[Mike Hommey [:glandium]]

> ::: moz.configure:62
> (Diff revision 1)
> > +@depends('--disable-compile-environment', '--help')
> > +def toolchain_include(value, help):
> > +    if value:
> > +        return 'build/moz.configure/toolchain.configure'
> > +
> > +include(toolchain_include)
> 
> This is an odd construct, I'm having a hard time forming a mental model of
> how it works. I'm OK with landing this as-is, but maybe we could file a
> followup on making this clearer?

Let's see how things evolve. I don't expect there will be more of this pattern (the other use is to include the application main moz.configure). I might decide to remove this one if it becomes cumbersome in the future (because there will have to be an alternative for the case the compile environment is disabled to have stubs, and there might be better alternatives than maintaining stubs ; we'll see)

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4a788be24b8a

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4a788be24b8a