Closed Bug 1259275 Opened 4 years ago Closed 4 years ago

"checking yasm version... Traceback" after "checking for yasm... not found"

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: glandium, Unassigned)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

Bug 1258785 dealt with not running the version check when yasm is not found, but the more fundamental problem is that we're checking yasm at all when doing builds without a compile environment.
Comment on attachment 8734174 [details]
MozReview Request: Bug 1259275 - Don't check for yasm when building with --disable-compile-environment. r?ted

https://reviewboard.mozilla.org/r/42129/#review38663

::: moz.configure:62
(Diff revision 1)
> +@depends('--disable-compile-environment', '--help')
> +def toolchain_include(value, help):
> +    if value:
> +        return 'build/moz.configure/toolchain.configure'
> +
> +include(toolchain_include)

This is an odd construct, I'm having a hard time forming a mental model of how it works. I'm OK with landing this as-is, but maybe we could file a followup on making this clearer?
Attachment #8734174 - Flags: review?(ted) → review+
> ::: moz.configure:62
> (Diff revision 1)
> > +@depends('--disable-compile-environment', '--help')
> > +def toolchain_include(value, help):
> > +    if value:
> > +        return 'build/moz.configure/toolchain.configure'
> > +
> > +include(toolchain_include)
> 
> This is an odd construct, I'm having a hard time forming a mental model of
> how it works. I'm OK with landing this as-is, but maybe we could file a
> followup on making this clearer?

Let's see how things evolve. I don't expect there will be more of this pattern (the other use is to include the application main moz.configure). I might decide to remove this one if it becomes cumbersome in the future (because there will have to be an alternative for the case the compile environment is disabled to have stubs, and there might be better alternatives than maintaining stubs ; we'll see)
https://hg.mozilla.org/mozilla-central/rev/4a788be24b8a
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.