1259042 - Re-introduce a version of ZoneCellIter for use under GC

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Jon Coppeard (:jonco)]

In bug 1244412 I removed ZoneCellIterUnderGC since I made ZoneCellIter work under GC too.  Subsequent harzard analysis warnings showed my why it was useful though: the analysis can see that it will never GC.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: bug1259042-zone-cell-iter-under-gc

Comment 2

[Terrence Cole [:terrence]]

How does this interact with bug 1240736 and bug 1244412? Seems like we'd be back to square one with those, right?

Comment 3

[Jon Coppeard (:jonco)]

(In reply to Terrence Cole [:terrence] from comment #2)
Nope, the problem wsa the use of ZoneCellIterUnderGC in TypeZone::clearAllNewScriptsOnOOM() which can be called from outside the GC.  This will continue to use ZoneCellIter which works when called from either collector or mutator code.

Comment 4

[Terrence Cole [:terrence]]

Comment on attachment 8734027 [details] [diff] [review]
bug1259042-zone-cell-iter-under-gc

Review of attachment 8734027 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for double-checking!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dbbe7c7e305d

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dbbe7c7e305d

Comment 7

[Jon Coppeard (:jonco)]

Comment on attachment 8734027 [details] [diff] [review]
bug1259042-zone-cell-iter-under-gc

Approval Request Comment
[Feature/regressing bug #]: Bug 1244412 I guess.
[User impact if declined]: Requesting uplift so we can uplift the fix for bug 1264300 which depends on this.
[Describe test coverage new/current, TreeHerder]: On m-c for over a month.
[Risks and why]: Low.
[String/UUID change made/needed]: None.

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8734027 [details] [diff] [review]
bug1259042-zone-cell-iter-under-gc

This patch is needed for another bug that meets the Beta uplift criteria, Beta47+

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This doesn't apply to beta, can we get a reworked patch?

Comment 10

[Jon Coppeard (:jonco)]

Attachment: bug1259042-beta

Backported patch for beta.

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f07d961162ad