Closed Bug 1259042 Opened 4 years ago Closed 4 years ago

Re-introduce a version of ZoneCellIter for use under GC

Categories

(Core :: JavaScript: GC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox47 --- fixed
firefox48 --- fixed

People

(Reporter: jonco, Assigned: jonco)

References

Details

Attachments

(2 files)

In bug 1244412 I removed ZoneCellIterUnderGC since I made ZoneCellIter work under GC too.  Subsequent harzard analysis warnings showed my why it was useful though: the analysis can see that it will never GC.
Attachment #8734027 - Flags: review?(terrence)
How does this interact with bug 1240736 and bug 1244412? Seems like we'd be back to square one with those, right?
Flags: needinfo?(jcoppeard)
(In reply to Terrence Cole [:terrence] from comment #2)
Nope, the problem wsa the use of ZoneCellIterUnderGC in TypeZone::clearAllNewScriptsOnOOM() which can be called from outside the GC.  This will continue to use ZoneCellIter which works when called from either collector or mutator code.
Flags: needinfo?(jcoppeard)
Comment on attachment 8734027 [details] [diff] [review]
bug1259042-zone-cell-iter-under-gc

Review of attachment 8734027 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for double-checking!
Attachment #8734027 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/dbbe7c7e305d
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Depends on: 1262203
No longer depends on: 1262203
Blocks: 1264300
Comment on attachment 8734027 [details] [diff] [review]
bug1259042-zone-cell-iter-under-gc

Approval Request Comment
[Feature/regressing bug #]: Bug 1244412 I guess.
[User impact if declined]: Requesting uplift so we can uplift the fix for bug 1264300 which depends on this.
[Describe test coverage new/current, TreeHerder]: On m-c for over a month.
[Risks and why]: Low.
[String/UUID change made/needed]: None.
Attachment #8734027 - Flags: approval-mozilla-beta?
Comment on attachment 8734027 [details] [diff] [review]
bug1259042-zone-cell-iter-under-gc

This patch is needed for another bug that meets the Beta uplift criteria, Beta47+
Attachment #8734027 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
This doesn't apply to beta, can we get a reworked patch?
Flags: needinfo?(jcoppeard)
Attached patch bug1259042-betaSplinter Review
Backported patch for beta.
Flags: needinfo?(jcoppeard)
Attachment #8750676 - Flags: review+
You need to log in before you can comment on or make changes to this bug.