1259174 - "File not found" errors in xpcshell/mozmill following bug 1242632

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[aleth [:aleth]]

Spun out of bug 1254987.

Note these failures can be reproduced locally.

Comment 1

[aleth [:aleth]]

Looks like it's not a relative path issue: objdir/_tests/xpcshell/mailnews/resources doesn't exist after the build.

Comment 2

[aleth [:aleth]]

Looks like Bug 1140161 has broken.

Comment 3

[aleth [:aleth]]

Probably by Bug 1242632.

Comment 4

[aleth [:aleth]]

Indeed, backing out bug 1242632 "fixes" this bug.

The relevant moz.builds with TEST_HARNESS_FILES absolute paths are 
mail/test/mozmill/moz.build
mailnews/moz.build

mshal, any ideas as to what might be going wrong?

Comment 5

[aleth [:aleth]]

I suspect https://hg.mozilla.org/mozilla-central/rev/bb230d696c72#l1.97 isn't the right thing to do when an absolute path is provided in TEST_HARNESS_FILES.

Comment 6

[aleth [:aleth]]

(By "absolute path" I mean https://hg.mozilla.org/mozilla-central/file/bb230d696c72/python/mozbuild/mozbuild/frontend/context.py#l1750)

Comment 7

[aleth [:aleth]]

Attachment: Fix absolute paths in TEST_HARNESS_FILES

This seems to fix the regression, but is possibly a bit of a hack.

Comment 8

[Michael Shal [:mshal]]

Comment on attachment 8734112 [details] [diff] [review]
Fix absolute paths in TEST_HARNESS_FILES

I think that seems reasonable. Though why do you need to add support for it at all? Couldn't you use local paths instead?


TEST_HARNESS_FILES.xpcshell.mailnews.data += [
    '/mailnews/test/data/**',
]

TEST_HARNESS_FILES.xpcshell.mailnews.resources += [
    '/mailnews/test/resources/**',
]

to:


TEST_HARNESS_FILES.xpcshell.mailnews.data += [
    'test/data/**',
]

TEST_HARNESS_FILES.xpcshell.mailnews.resources += [
    'test/resources/**',
]

Comment 9

[aleth [:aleth]]

(In reply to Michael Shal [:mshal] from comment #8)
> TEST_HARNESS_FILES.xpcshell.mailnews.resources += [
>     'test/resources/**',
> ]

The problem is that this would end up with files copied to .../xpcshell/mailnews/resources/test/resources.

Comment 10

[aleth [:aleth]]

Comment on attachment 8734112 [details] [diff] [review]
Fix absolute paths in TEST_HARNESS_FILES

Note this simple patch would fail if there are absolute paths with wildcards in the middle somewhere (/whatever/*/something); not sure if that is supported.

Comment 11

[aleth [:aleth]]

(In reply to aleth [:aleth] from comment #9)
> The problem is that this would end up with files copied to
> .../xpcshell/mailnews/resources/test/resources.

One might be able to work around that one, but this example here seems impossible:

https://dxr.mozilla.org/comm-central/source/mail/test/mozmill/moz.build#12

Comment 12

[aleth [:aleth]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8b62c5b05ff1fee583c76e8c697e51e8f823aadc
Bug 1259174 - Fix absolute paths in TEST_HARNESS_FILES. r=mshal

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8b62c5b05ff1