Closed Bug 1259174 Opened 4 years ago Closed 4 years ago

"File not found" errors in xpcshell/mozmill following bug 1242632

Categories

(Firefox Build System :: General, defect)

48 Branch
defect
Not set

Tracking

(firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: aleth, Assigned: aleth)

References

Details

(Keywords: regression)

Attachments

(1 file)

Spun out of bug 1254987.

Note these failures can be reproduced locally.
Blocks: 1254987
Keywords: regression
Looks like it's not a relative path issue: objdir/_tests/xpcshell/mailnews/resources doesn't exist after the build.
Looks like Bug 1140161 has broken.
Probably by Bug 1242632.
Depends on: 1259219
Indeed, backing out bug 1242632 "fixes" this bug.

The relevant moz.builds with TEST_HARNESS_FILES absolute paths are 
mail/test/mozmill/moz.build
mailnews/moz.build

mshal, any ideas as to what might be going wrong?
Blocks: 1242632
No longer depends on: 1259219
Flags: needinfo?(mshal)
I suspect https://hg.mozilla.org/mozilla-central/rev/bb230d696c72#l1.97 isn't the right thing to do when an absolute path is provided in TEST_HARNESS_FILES.
This seems to fix the regression, but is possibly a bit of a hack.
Attachment #8734112 - Flags: feedback?(mshal)
Assignee: nobody → aleth
Status: NEW → ASSIGNED
No longer blocks: 1254987
Product: Thunderbird → Core
Summary: "File not found" errors in xpcshell/mozmill following recent configure changes → "File not found" errors in xpcshell/mozmill following bug 1242632
Comment on attachment 8734112 [details] [diff] [review]
Fix absolute paths in TEST_HARNESS_FILES

I think that seems reasonable. Though why do you need to add support for it at all? Couldn't you use local paths instead?


TEST_HARNESS_FILES.xpcshell.mailnews.data += [
    '/mailnews/test/data/**',
]

TEST_HARNESS_FILES.xpcshell.mailnews.resources += [
    '/mailnews/test/resources/**',
]

to:


TEST_HARNESS_FILES.xpcshell.mailnews.data += [
    'test/data/**',
]

TEST_HARNESS_FILES.xpcshell.mailnews.resources += [
    'test/resources/**',
]
Flags: needinfo?(mshal)
Attachment #8734112 - Flags: feedback?(mshal) → feedback+
(In reply to Michael Shal [:mshal] from comment #8)
> TEST_HARNESS_FILES.xpcshell.mailnews.resources += [
>     'test/resources/**',
> ]

The problem is that this would end up with files copied to .../xpcshell/mailnews/resources/test/resources.
Comment on attachment 8734112 [details] [diff] [review]
Fix absolute paths in TEST_HARNESS_FILES

Note this simple patch would fail if there are absolute paths with wildcards in the middle somewhere (/whatever/*/something); not sure if that is supported.
Attachment #8734112 - Flags: review?(mshal)
(In reply to aleth [:aleth] from comment #9)
> The problem is that this would end up with files copied to
> .../xpcshell/mailnews/resources/test/resources.

One might be able to work around that one, but this example here seems impossible:

https://dxr.mozilla.org/comm-central/source/mail/test/mozmill/moz.build#12
Attachment #8734112 - Flags: review?(mshal)
Attachment #8734112 - Flags: review+
Attachment #8734112 - Flags: feedback+
https://hg.mozilla.org/mozilla-central/rev/8b62c5b05ff1
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.